[FileBasedConfiguration] General Settings #4481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kielek
reviewed
Oct 2, 2025
| { | ||
| SetupSdk = !configuration.Disabled; | ||
| FlushOnUnhandledException = configuration.FlushOnUnhandledException; | ||
| } |
There was a problem hiding this comment.
Mandatory for this PR: You need to set up here also ProfilerEnabled (by fallback to envs).
Plugins are alsoe required, but it can be configured also from the file. If you want to make a follow up PR, you need to ensure that it is extracted to separate setting, and readed from EvnVars.
There was a problem hiding this comment.
Plugins will be added in separate PR.
Kielek
approved these changes
Oct 6, 2025
| FlushOnUnhandledException = configuration.FlushOnUnhandledException; | ||
|
|
||
| ProfilerEnabled = configuration.EnableProfiling; | ||
| ProfilerEnabled = Environment.GetEnvironmentVariable(ConfigurationKeys.ProfilingEnabled) == "1"; |
There was a problem hiding this comment.
Maybe you can put here some comment why you are using direclty env vars
There was a problem hiding this comment.
Comment added in b380a12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Towards #4394
Extracted and refactored from #4270
What
File based configuration for General Settings
Tests
CI
Checklist
CHANGELOG.mdis updated.