Skip to content

[sdk] Simplify dispose code in SelfDiagnostics#6072

Merged
CodeBlanch merged 3 commits intoopen-telemetry:mainfrom
SimonCropp:remove-redundant-dispose-code-in-SelfDiagnostics
Jan 22, 2025
Merged

[sdk] Simplify dispose code in SelfDiagnostics#6072
CodeBlanch merged 3 commits intoopen-telemetry:mainfrom
SimonCropp:remove-redundant-dispose-code-in-SelfDiagnostics

Conversation

@SimonCropp
Copy link
Contributor

Fixes #
Design discussion issue #

Changes

GC.SuppressFinalize is only required when a class has a finalizer. and the SuppressFinalize+Finalizer pattern is only required when u want release unmanaged resources

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@SimonCropp SimonCropp requested a review from a team as a code owner January 17, 2025 22:23
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 17, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: SimonCropp / name: Simon Cropp (978bd8e, 065930d)
  • ✅ login: CodeBlanch / name: Mikel Blanchard (8e99eeb)

@github-actions github-actions bot added the pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package label Jan 17, 2025
@SimonCropp
Copy link
Contributor Author

bump

@CodeBlanch CodeBlanch changed the title remove redundant dispose code in SelfDiagnostics [sdk] Simplify dispose code in SelfDiagnostics Jan 22, 2025
@CodeBlanch CodeBlanch merged commit 54f7d9e into open-telemetry:main Jan 22, 2025
39 checks passed
@codecov
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.39%. Comparing base (6e8e190) to head (8e99eeb).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6072      +/-   ##
==========================================
- Coverage   86.40%   86.39%   -0.01%     
==========================================
  Files         257      257              
  Lines       11656    11650       -6     
==========================================
- Hits        10071    10065       -6     
  Misses       1585     1585              
Files with missing lines Coverage Δ
src/OpenTelemetry/Internal/SelfDiagnostics.cs 100.00% <ø> (ø)

@SimonCropp SimonCropp deleted the remove-redundant-dispose-code-in-SelfDiagnostics branch January 22, 2025 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants