simplify EnvironmentVariablesConfigurationProvider.Load

[SimonCropp]

Fixes #
Design discussion issue #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

• CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
• Unit tests added/updated
• Appropriate CHANGELOG.md files updated for non-trivial changes
• Changes in public API reviewed (if applicable)

[Kielek]

From the header of the file:

// <auto-generated /> (Turns off StyleCop analysis in this file.)
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

I suppose that the current construction is for the reason.
Maybe benchmarking? Did you have chance to verify it/and or double check the source of the file?

[SimonCropp]

@Kielek what generates this file?

[Kielek]

Please check #4092. It is marked as generated to avoid stylecop check

[SimonCropp]

so if u manually duplicate a file, without also duplicating the tooling that generates it, then it is no longer a generated file

[Kielek]

Yes, it is copied, and adjusted, but all parts are still valid:

1. Are there any changes in the source of the file?
2. I suppose that the current construction is for the reason. Maybe benchmarking? Did you have chance to verify it/and or double check the source of the file?

[rajkumar-rangaraj]

@SimonCropp The reason for the while loop is the same as described in this discussion, and it is from a file copied from the .NET runtime. How do you want to proceed on this PR?

[github-actions]

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.40%. Comparing base (b508b84) to head (73cbc86).
Report is 9 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6095   +/-   ##
=======================================
  Coverage   86.40%   86.40%           
=======================================
  Files         257      257           
  Lines       11649    11649           
=======================================
  Hits        10065    10065           
  Misses       1584     1584