[Infra] Ensure .NET 8 is installed #6313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that .NET 8 is installed on the runner. The workflows currently assume it is installed, which causes failures on ARM64 runners where it is not installed by default.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #6313 +/- ##
==========================================
- Coverage 86.72% 86.69% -0.03%
==========================================
Files 258 258
Lines 11879 11879
==========================================
- Hits 10302 10299 -3
- Misses 1577 1580 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that .NET 8 is installed on the GitHub runner to prevent failures on ARM64 runners.
- Adds a dedicated step to install .NET 8.0.x using actions/setup-dotnet
- Retains an existing step for setting up other .NET runtimes
Comments suppressed due to low confidence (1)
.github/workflows/Component.BuildTest.yml:56
- The step name 'Setup previous .NET runtimes' is ambiguous given that it installs .NET 8.0.x. Consider renaming it to 'Setup .NET 8' for clarity.
- - name: Setup previous .NET runtimes
alanwest
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Ensure that .NET 8 is installed on the runner. The workflows currently assume it is installed, which causes failures on ARM64 runners where it is not installed by default.
Found in open-telemetry/opentelemetry-dotnet-contrib#2832 and also #6307.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes