Reset scale of exponential histogram #6557
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m/hannahhaering/opentelemetry-dotnet into exponential-histogram-reset-scale
github-actions
bot
added
the
pkg:OpenTelemetry
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6557 +/- ##
==========================================
- Coverage 86.67% 86.65% -0.02%
==========================================
Files 258 258
Lines 11895 11896 +1
==========================================
- Hits 10310 10309 -1
- Misses 1585 1587 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
martincostello
approved these changes
Oct 2, 2025
Kielek
reviewed
Oct 6, 2025
src/OpenTelemetry/Metrics/MetricPoint/Base2ExponentialBucketHistogram.cs
Outdated
Show resolved
Hide resolved
| this.runningValue.AsLong = 0; | ||
| histogram.RunningSum = 0; | ||
| histogram.Reset(); | ||
| histogram.Reset(false); |
There was a problem hiding this comment.
These callsites would be more readable with a named-parameter:
Suggested change
| histogram.Reset(false); | |
| histogram.Reset(isMinMax: false); |
| histogram.Reset(); | ||
| histogram.RunningMin = double.PositiveInfinity; | ||
| histogram.RunningMax = double.NegativeInfinity; | ||
| histogram.Reset(true); |
There was a problem hiding this comment.
Suggested change
| histogram.Reset(true); | |
| histogram.Reset(isMinMax: true); |
| else | ||
| { | ||
| expectedHistogram.Reset(); | ||
| expectedHistogram.Reset(aggregationType == AggregationType.HistogramWithMinMax); |
There was a problem hiding this comment.
Suggested change
| expectedHistogram.Reset(aggregationType == AggregationType.HistogramWithMinMax); | |
| expectedHistogram.Reset(isMinMax: aggregationType == AggregationType.HistogramWithMinMax); |
| AssertExponentialBucketsAreCorrect(expectedHistogram, metricPoint.GetExponentialHistogramData()); | ||
| Assert.Equal(50, sum); | ||
| Assert.Equal(6, count); | ||
| Assert.True(firstScale <= Metric.DefaultExponentialHistogramMaxScale); |
There was a problem hiding this comment.
Or some alternate message. We want more meaningful output in the logs if the test fails than "Expected true but got false".
Suggested change
| Assert.True(firstScale <= Metric.DefaultExponentialHistogramMaxScale); | |
| Assert.True(firstScale <= Metric.DefaultExponentialHistogramMaxScale, "The first scale value, {0}, is greater than Metric.DefaultExponentialHistogramMaxScale.", firstScale); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5635
Changes
Reset scale to 20 of the Base2 Exponential Bucket Histogram after each collection cycle when using delta aggregation temporality.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes