Skip to content

Conversation

martincostello
Copy link
Member

Changes

#6564 with the downgrade of the OpenTelemetry Collector to v0.133.0 to demonstrate detection of #6464 and #6538.

Not intended to be ever merged.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

- Refactor tests to use `[MemberData]` to avoid duplication.
- Fix code analysis suggestions.
- Log event level.
Verify that there are no warnings or errors during the integration tests.
Refactor tests to de-duplicate assertion code.
- Add a gauge and a histogram to the metrics test.
- Rename variable.
- Refactor use of `Assert.Single()`.
Log the HTTP response body, if available.

Resolves open-telemetry#6454.
Downgrade the collector to verify the tests detect the issue.
@github-actions github-actions bot added the pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package label Oct 3, 2025
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.61%. Comparing base (6a70665) to head (d0e6c36).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6565      +/-   ##
==========================================
- Coverage   86.70%   86.61%   -0.09%     
==========================================
  Files         258      258              
  Lines       11895    11909      +14     
==========================================
+ Hits        10313    10315       +2     
- Misses       1582     1594      +12     
Flag Coverage Δ
unittests-Project-Experimental 86.53% <94.73%> (+0.15%) ⬆️
unittests-Project-Stable 86.58% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ol/Implementation/ExportClient/OtlpExportClient.cs 100.00% <100.00%> (ø)
...mplementation/ExportClient/OtlpGrpcExportClient.cs 76.34% <100.00%> (+1.06%) ⬆️
...mplementation/ExportClient/OtlpHttpExportClient.cs 100.00% <100.00%> (ø)
...tation/OpenTelemetryProtocolExporterEventSource.cs 83.33% <100.00%> (-1.20%) ⬇️

... and 4 files with indirect coverage changes

@martincostello
Copy link
Member Author

Test confirmed failing as expected.

@martincostello martincostello deleted the gh-6463-repro branch October 3, 2025 11:05
martincostello added a commit to martincostello/opentelemetry-dotnet that referenced this pull request Oct 6, 2025
Tests in this PR pass and otherwise validated using open-telemetry#6565.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant