Skip to content

Conversation

mmat11
Copy link
Contributor

@mmat11 mmat11 commented Aug 14, 2025

@mmat11 mmat11 requested a review from a team as a code owner August 14, 2025 14:16
Copy link

codecov bot commented Aug 14, 2025

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.65%. Comparing base (dd1c8b9) to head (112ea8f).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
...g/components/ebpf/common/kafka_detect_transform.go 0.00% 6 Missing ⚠️
pkg/app/request/span.go 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (dd1c8b9) and HEAD (112ea8f). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (dd1c8b9) HEAD (112ea8f)
unittests 1 0
oats-test 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #464       +/-   ##
===========================================
- Coverage   66.01%   54.65%   -11.36%     
===========================================
  Files         222      188       -34     
  Lines       23069    20701     -2368     
===========================================
- Hits        15228    11314     -3914     
- Misses       7053     8561     +1508     
- Partials      788      826       +38     
Flag Coverage Δ
integration-test-arm 34.24% <0.00%> (+0.18%) ⬆️
k8s-integration-test 51.28% <0.00%> (+0.10%) ⬆️
oats-test ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marctc
Copy link
Contributor

marctc commented Aug 14, 2025

* Add some kafka integration tests: python, java (2.8.0), java (4.0.0)

are those convering something OATS tests are not doing? should we consolidate?

@mmat11
Copy link
Contributor Author

mmat11 commented Aug 14, 2025

* Add some kafka integration tests: python, java (2.8.0), java (4.0.0)

are those convering something OATS tests are not doing? should we consolidate?

I guess the java tests for version 2.8.0 are overlapping with OATS tests. I had to write them because it's much easier to debug via integration tests than it is via OATS. I can remove those if we don't want overlap

@mmat11 mmat11 force-pushed the matt/kafka-fix branch 3 times, most recently from 75bb9c1 to 52fb6a0 Compare August 20, 2025 14:29
@MrAlias MrAlias merged commit 5fc9c63 into open-telemetry:main Sep 3, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants