-
Notifications
You must be signed in to change notification settings - Fork 57
Create placeholder for meter_provider declarative configuration #943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #943 +/- ##
==========================================
+ Coverage 47.13% 56.32% +9.18%
==========================================
Files 255 255
Lines 22139 22142 +3
==========================================
+ Hits 10436 12472 +2036
+ Misses 11041 8825 -2216
- Partials 662 845 +183
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| otel_traces_export: | ||
| endpoint: http://jaeger:4318 | ||
| meter_provider: | ||
| obi_features: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we call them obi_features, instead of features?
In preparation for #903:
otel_metric_export > featuresto a commonmeter_provider > features, and deprecate itprometheus > featurestometer_provider > features, and deprecate itopentelemetry.iodocs as soon as the new format is accepted/agreed.The reason to move the features specification to a common section is because in the next PRs, we will allow a declarative per-service metric features definition. Having different metric features per export endpoint adds a lot of complexity to the code.