Sample frames to include column information in addition to line numbers

[manojVivek]

Resolves #823

Contains:

• Extracting column info in v8 profiler
• Passing the extracted column info with the sample frames

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: manojVivek / name: Manoj Vivek (17fc65e, 327c0c7, 4b01c82, 89ec581)

[florianl]

Should be related to #823 not #283.

[manojVivek]

Should be related to #823 not #283.

My bad, fixed it.

[florianl]

Can you please also update coredumps to include the column information?

Maybe something like this:

columnInfo := ""
if frame.SourceColumn != 0 {
    columnInfo = fmt.Sprintf(":%d", frame.SourceColumn)
}
fmt.Sprintf("%s+%d in %s:%d%s",
			frame.FunctionName, frame.FunctionOffset,
			frame.SourceFile, frame.SourceLine, columnInfo)

[manojVivek]

Can you please also update coredumps to include the column information?

This is done.

[florianl]

@manojVivek coredump tests are failing now (as expected), as the column information is now also provided, but not present in files like https://github.com/open-telemetry/opentelemetry-ebpf-profiler/blob/main/tools/coredump/testdata/amd64/node211.json.

[manojVivek]

@manojVivek coredump tests are failing now (as expected), as the column information is now also provided, but not present in files like https://github.com/open-telemetry/opentelemetry-ebpf-profiler/blob/main/tools/coredump/testdata/amd64/node211.json.

(yeah, sorry for the ping before resolving that fully)

I believe it should be passing now, it works on the arm Mac. Also updated the files similarly for the amd64, but didn't get a chance to test it locally so waiting for the CI run.

[fabled]

Looks good. One nit. And question for all if the line/column data type could or should be changed to 32 bit size?

[fabled]

I wonder if this should be made uint32 and the above SourceLineno also to reduce memory use?

[manojVivek]

No major concerns from me, except that otel protobuf spec has declared this as int64 too here: https://github.com/open-telemetry/opentelemetry-proto/blob/0d02f212598f3ec1dda35274e87f59351f619058/opentelemetry/proto/profiles/v1development/profiles.proto#L437

[fabled]

And here also, line/column probably could be int32?

[fabled]

This else branch is unneeded. line start is initialized to zero.

[manojVivek]

Done, fixed this.