Move rt_regs from stack to record scratch#1286
Open
gnurizen wants to merge 1 commit intoopen-telemetry:mainfrom
Open
Move rt_regs from stack to record scratch#1286gnurizen wants to merge 1 commit intoopen-telemetry:mainfrom
gnurizen wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
Contributor
Author
|
I was hoping for this PR to just be one commit relative to PR 1280 but GH requires base branch to be in this repo. |
gnurizen
force-pushed
the
shrink-stack
branch
2 times, most recently
from
c8ee363 to
0cf56fc
Compare
Contributor
|
I think the commit to move |
Contributor
Author
|
Yeah I can rebase this to main and make it standalone and pull this out of the commit set in #1288 |
Contributor
Author
|
Rebased to main and RFAL. |
On arm64, rt_regs[34] consumes 272 bytes of the 512-byte BPF stack. When unwind_one_frame is inlined into interpreter unwinders, this exceeds the stack limit. Move rt_regs into the PerCPURecord scratch union which is already 1024+ bytes and unused during signal frame handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another prep the patient PR for a hybrid python native unwinder. Combining the two unwinders exhausted the bpf stack and this fixes it.