WIP: Use BPF ringbuf to transmit trace events from kernel to userspace#1339
Open
christos68k wants to merge 6 commits intoopen-telemetry:mainfrom
Open
WIP: Use BPF ringbuf to transmit trace events from kernel to userspace#1339christos68k wants to merge 6 commits intoopen-telemetry:mainfrom
christos68k wants to merge 6 commits intoopen-telemetry:mainfrom
Conversation
christos68k
force-pushed
the
ck/ringbuf
branch
2 times, most recently
from
93cc658 to
4cf4bfa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switches our trace event transmission logic from perf events to BPF ringbuf.
I tried to keep existing semantics regarding the following two behaviors, and if we decide to pursue changes there, I'd rather we open follow-up PRs as I want to keep this PR as simple as possible in terms of semantic changes:
bpf_ringbuf_reserve/bpf_ringbuf_submitinstead ofbpf_ringbuf_output(building the trace incrementally inside the reserved region).I have one or two more TODOs to address but feel free to review.
CC: @gnurizen