Add support for java agent file format 0.3 in explorer db#211
Open
jaydeluca wants to merge 4 commits intoopen-telemetry:mainfrom
Open
Add support for java agent file format 0.3 in explorer db#211jaydeluca wants to merge 4 commits intoopen-telemetry:mainfrom
jaydeluca wants to merge 4 commits intoopen-telemetry:mainfrom
Conversation
✅ Deploy Preview for otel-ecosystem-explorer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Updates the explorer and DB builder to align with the Java agent registry file_format: 0.3 metric schema (renaming the metric field from type to data_type and introducing instrument), and adjusts related UI/test fixtures accordingly.
Changes:
- Update frontend Java agent metric typings and UI rendering to use
instrument/data_type. - Update frontend tests to use the new metric shape.
- Extend the DB builder instrumentation transformer/tests to recognize
file_format: 0.3and transform older formats toward 0.3.
Reviewed changes
Copilot reviewed 10 out of 13 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| ecosystem-explorer/src/types/javaagent.ts | Updates Metric shape from type to instrument + data_type. |
| ecosystem-explorer/src/features/java-agent/utils/badge-info.test.ts | Updates test fixtures to the new metric shape. |
| ecosystem-explorer/src/features/java-agent/java-instrumentation-list-page.test.tsx | Updates list-page test fixtures to new metric fields. |
| ecosystem-explorer/src/features/java-agent/components/telemetry-section.tsx | Renders metric badge using metric.instrument instead of metric.type. |
| ecosystem-explorer/src/features/java-agent/components/telemetry-section.test.tsx | Updates telemetry-section tests to use new metric fields. |
| ecosystem-explorer/src/features/java-agent/components/instrumentation-group-card.test.tsx | Updates group-card fixtures and version expectations. |
| ecosystem-explorer/src/features/java-agent/components/instrumentation-card.test.tsx | Updates card fixtures to new metric fields. |
| ecosystem-explorer/src/features/java-agent/components/configuration-selector.test.tsx | Updates selector fixtures to new metric fields. |
| ecosystem-automation/explorer-db-builder/tests/test_instrumentation_transformer.py | Updates transformer tests for 0.3 passthrough + 0.2/0.1 upgrade path. |
| ecosystem-automation/explorer-db-builder/src/explorer_db_builder/instrumentation_transformer.py | Adds 0.2→0.3 transform and 0.3 passthrough logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ecosystem-automation/explorer-db-builder/src/explorer_db_builder/instrumentation_transformer.py
Show resolved
Hide resolved
ecosystem-explorer/src/features/java-agent/components/configuration-selector.test.tsx
Show resolved
Hide resolved
ecosystem-automation/explorer-db-builder/tests/test_instrumentation_transformer.py
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support in the database builder for the new
0.3file format, which changed the metrictypetodata_typeand addedinstrument.Another note, I am deleting the
ecosystem-registryentries for the metadata for versions below the latest (2.26.1). The reason for this is because 2.26.1 is the release where I finished populating the base metadata for everything, and I would like to actually use 2.27.0 as the floor of the versions we track and support for the website, since that's when the data will be the most complete.After this is merged, I will re-run the db builder pipeline with the
--cleanflag to nuke earlier versions in the database (ecosystem-explorer/public/data/javaagent).Eventually we can delete some of the transformation code in the java agent watcher and db builder, but we can leave it for now in case we decide we do want to support older versions for some reason.