Skip to content

Add tests to cover new liveview integration #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2023
Merged

Add tests to cover new liveview integration #221

merged 1 commit into from
Nov 10, 2023

Conversation

derekkraan
Copy link
Contributor

@derekkraan derekkraan commented Nov 1, 2023 •
edited
Loading

Following up on #198.

tsloughter
tsloughter approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@tsloughter tsloughter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I would like @bryannaegele to take a look before its merged, but I'm approving.

@derekkraan
Copy link
Contributor Author

Is there a reason that all the tests in the matrix are being skipped?

@bryannaegele
Copy link
Contributor

Is there a reason that all the tests in the matrix are being skipped?

Forks can't trigger test runs without a maintainer giving it the initial trigger, I think. There's something there about that.

Given the number of tests we have and that the runners are shared with all of otel, I'm inclined to not change the behavior.

@github-actions github-actions bot removed the scope-ci label Nov 8, 2023
@derekkraan
Copy link
Contributor Author

Fixed the tests. Not sure why mix format ran with another version of Elixir when I submitted initially. This PR is ready for another look.

@bryannaegele bryannaegele merged commit 5caf10a into open-telemetry:main Nov 10, 2023
@yordis yordis mentioned this pull request Dec 12, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tsloughter tsloughter tsloughter approved these changes

@bryannaegele bryannaegele bryannaegele approved these changes

Assignees

No one assigned

Labels

elixir instrumentation opentelemetry_phoenix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@derekkraan @bryannaegele @tsloughter