Move opentelemetry_absinthe to instrumentation#369
Move opentelemetry_absinthe to instrumentation#369cpiemontese wants to merge 11 commits intoopen-telemetry:mainfrom
Conversation
|
I also took the opportunity to update CODEOWNERS for both this and Bonus question: I added |
|
@bryannaegele @tsloughter What are your thoughts about getting this merged? Are we just waiting on a more thorough review, or is there more to it than that? I can probably find some time to do that review soonish. |
|
@tsloughter I just noticed that the fork we have isn't under the org; do you think we could get this in? I would like to make it up to date with SemConv and so on |
|
@yordis @cpiemontese What's the status on this? |
|
@yordis so you want this one merged? Have you reviewed and compared to your fork? |
|
@tsloughter I would probably merge this one first, and then I follow up on whatever works needs to be done |
|
Ok. Then the conflict just has to be resolved. |
|
@cpiemontese are you able to fix the merge conflict or would like me to do it? |
|
Done ✅ |
yordis
left a comment
There was a problem hiding this comment.
We need to follow on up this one since we should have nimbleoptions, semconv 27+ and so on.
But we can do that in a follow up PRs instead.
This PR moves the code for
opentelemetry_absintheunder theinstrumentationfolder