Skip to content

Comments

Move opentelemetry_absinthe to instrumentation#369

Open
cpiemontese wants to merge 11 commits intoopen-telemetry:mainfrom
cpiemontese:opentelemetry-absinthe-handover
Open

Move opentelemetry_absinthe to instrumentation#369
cpiemontese wants to merge 11 commits intoopen-telemetry:mainfrom
cpiemontese:opentelemetry-absinthe-handover

Conversation

@cpiemontese
Copy link
Contributor

This PR moves the code for opentelemetry_absinthe under the instrumentation folder

@cpiemontese
Copy link
Contributor Author

I also took the opportunity to update CODEOWNERS for both this and opentelemetry_httpoison.

Bonus question: I added absinthe as an option for the release dispatch workflow, who can publish these versions though...?

@GregMefford
Copy link
Contributor

GregMefford commented Oct 15, 2024

@bryannaegele @tsloughter What are your thoughts about getting this merged? Are we just waiting on a more thorough review, or is there more to it than that? I can probably find some time to do that review soonish.

@yordis
Copy link
Member

yordis commented Feb 4, 2026

@tsloughter I just noticed that the fork we have isn't under the org; do you think we could get this in? I would like to make it up to date with SemConv and so on

@perzanko
Copy link

perzanko commented Feb 19, 2026

@yordis @cpiemontese What's the status on this?

@tsloughter
Copy link
Member

@yordis so you want this one merged? Have you reviewed and compared to your fork?

@yordis
Copy link
Member

yordis commented Feb 19, 2026

@tsloughter I would probably merge this one first, and then I follow up on whatever works needs to be done

@tsloughter
Copy link
Member

Ok. Then the conflict just has to be resolved.

@yordis
Copy link
Member

yordis commented Feb 19, 2026

@cpiemontese are you able to fix the merge conflict or would like me to do it?

@cpiemontese
Copy link
Contributor Author

Done ✅

Copy link
Member

@yordis yordis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to follow on up this one since we should have nimbleoptions, semconv 27+ and so on.

But we can do that in a follow up PRs instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants