Skip to content

Fix OpentelemetryPhoenix tests #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix OpentelemetryPhoenix tests #448

wants to merge 1 commit into from

Conversation

danschultzer
Copy link
Contributor

@danschultzer danschultzer commented Jan 8, 2025 •
edited
Loading

Resolves the current failing tests in main. There seems to be some race condition introduced.

Instead of starting and stopping the telemetry app it's easier to just detach all listeners when the test ends.

@danschultzer danschultzer mentioned this pull request Jan 9, 2025
Draft
@kenichi kenichi mentioned this pull request Jan 22, 2025
Merged
@danschultzer danschultzer mentioned this pull request Apr 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bryannaegele bryannaegele Awaiting requested review from bryannaegele bryannaegele is a code owner

@tsloughter tsloughter Awaiting requested review from tsloughter tsloughter is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

elixir instrumentation opentelemetry_phoenix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@danschultzer