Skip to content

Conversation

JohnDoneth
Copy link

@JohnDoneth JohnDoneth commented Jan 27, 2025

It appears that WebSockets are reported as having a nil conn.status to the telemetry handler. Due to the conditional in the telemetry handler nil statuses are interpreted as errors (when they are functioning as expected) due to nil >= 500 evaluating to true.

Copy link

linux-foundation-easycla bot commented Jan 27, 2025

CLA Not Signed

@bryannaegele
Copy link
Contributor

bryannaegele commented Jan 29, 2025

Can you sign the cla?

And is there any way to discern if it's a websocket closing after upgrade? Just so it's clear in tests and comments that this is expected and not open a hole in test coverage.

@JohnDoneth
Copy link
Author

@bryannaegele I'm still working through with my company on how to proceed with the CLA. I will attempt to adjust the code if possible to see if it's a websocket upgrade once I get word on the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants