fix: Avoid ignoring Parent Span #509
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The committers listed above are authorized under a signed CLA. |
indrekj
reviewed
May 23, 2025
| parent = OpenTelemetry.Tracer.current_span_ctx() | ||
| links = if parent == :undefined, do: [], else: [OpenTelemetry.link(parent)] | ||
| OpenTelemetry.Tracer.set_current_span(:undefined) | ||
| OpenTelemetry.Tracer.set_current_span(parent) |
There was a problem hiding this comment.
IIRC, I did it because we already create an Opentelemetry link. If we also set the parent, then we have both a link and a direct relationship. Can you link from the opentelemetry docs that this should not be a link?
There was a problem hiding this comment.
I understand @indrekj , I'm not sure if it shouldn't be a link or not, I just evaluated how it was logged at Datadog, and I missed the parent in the whole tree of traces.
So, I don't have a solid argument to say if it should or not. In case not we can close the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on #508,
Oban.JobHandlerseems not to be setting the right span, ignoring the parent, causing a break in the traces for a flow. This fix allows the parent span to be included in the traces.In case a parent span doesn't exist, it'll have the value
:undefined, exactly what has been set by default in the current code.