Widen allowed semantic_conventions for tesla and oban #514
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Thank you for maintaining the project!
I'd like to widen allowed versions of semantic_conventions for tesla and oban.
The reason is, that we are using tesla, oban and cowboy together.
Tesla and Oban depend on v0.2 and cobowy depends on v1.27.
This meant, we were not able to upgrade.
It seems that the upgrade to 1.27 is backwards compatible. We've used
{:opentelemetry_semantic_conventions, "~> 1.27", override: true}
in our config and both Oban and Tesla work without any issues.There are other places that still depend on semantic_conventions 0.2:
If you can confirm that the changes between 0.2 and 1.27 are fully backwards compatible, I could update those places too in one go. However, I am not 100% sure, so I am only updating those that we used in production.