feat:(opentelemetry_broadway): add context propagation integration #540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yordis
force-pushed
the
yordis/broadway-1
branch
2 times, most recently
from
79183e2 to
015bb74
Compare
|
Nice 👍 I'll review this today. |
tsloughter
reviewed
Aug 15, 2025
instrumentation/opentelemetry_broadway/lib/opentelemetry_broadway.ex
Outdated
Show resolved
Hide resolved
tsloughter
reviewed
Aug 15, 2025
yordis
force-pushed
the
yordis/broadway-1
branch
3 times, most recently
from
6fe3da2 to
0a73bff
Compare
tsloughter
reviewed
Aug 23, 2025
yordis
force-pushed
the
yordis/broadway-1
branch
from
0a73bff to
59eb992
Compare
|
Hey @tsloughter any updates here? |
|
@whatyouhide could you share some blessing here? 🙏🏻 |
|
I think this should be enabled by default, https://github.com/open-telemetry/semantic-conventions/blob/main/docs/messaging/messaging-spans.md Another piece, which can wait for a future PR, is it should optionally be able to make the producer the parent and not just a link. |
yordis
force-pushed
the
yordis/broadway-1
branch
from
59eb992 to
eeca580
Compare
|
@tsloughter I made it enabled by default |
Signed-off-by: Yordis Prieto <[email protected]>
yordis
force-pushed
the
yordis/broadway-1
branch
from
154e46c to
a02bc86
Compare
|
@whatyouhide you are owner, it seems you must approve it |
tsloughter
approved these changes
Sep 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.