-
Notifications
You must be signed in to change notification settings - Fork 149
feat(opentelemetry_grpc): add initial setup for opentelemetry_grpc #554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
7a1f888
to
e82f17e
Compare
instrumentation/opentelemetry_grpc/lib/opentelemetry_grpc/client.ex
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry_grpc/lib/opentelemetry_grpc/client.ex
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry_grpc/lib/opentelemetry_grpc/client.ex
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry_grpc/lib/opentelemetry_grpc/client.ex
Outdated
Show resolved
Hide resolved
2f685df
to
396975f
Compare
1cb549c
to
14faa20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@yordis I'm not a maintainer of this project, but PR looks good to me |
d553114
to
173ba90
Compare
9a397be
to
4516097
Compare
@sleipnir do you mind giving it another code review; by now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor comments, we're getting there, congratulations.
What do you think about adding a small benchmark, comparing the interceptor for client and server? If it's not too much work, of course.
instrumentation/opentelemetry_grpc/lib/opentelemetry_grpc/server.ex
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry_grpc/lib/opentelemetry_grpc/server.ex
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry_grpc/lib/opentelemetry_grpc/server.ex
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry_grpc/lib/opentelemetry_grpc/server.ex
Outdated
Show resolved
Hide resolved
@sleipnir thank you so much for the review; I am gonna wait for @tsloughter input to tackle the comments and other things, some of them are there to actually help me to make sense of things, I honestly keep getting confused with Linking vs Child; and a nice pattern to follow |
Thanks for reviewing @sleipnir |
It doesn't have to be this way, but it might be a little cleaner if everything was done in the interceptors, instead of creating the spans in telemetry events and doing context propagation in the interceptor. |
@tsloughter the downside of doing that is that, you need to register the interceptor for every single client; |
You're welcome <3 |
a5e534a
to
df85958
Compare
2ca2202
to
478b5db
Compare
Signed-off-by: Yordis Prieto <[email protected]>
478b5db
to
e2ee9e2
Compare
Signed-off-by: Yordis Prieto [email protected]