chore: switch to commitlint.js for checking the commit msgs in CI #918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #918 +/- ##
=======================================
Coverage 17.66% 17.66%
=======================================
Files 24 24
Lines 719 719
=======================================
Hits 127 127
Misses 592 592
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
loos like the node setup is failing for lack of lock files? |
|
wtf that does't make any sense. I use an explicit install, This is |
|
Wow.. really can't actions/setup-node#928 |
|
There is a hack mentioned to do it by disabling cache. I'll do that and can manually do a cache later of the packages. |
This allows us to have some control over what is an allowed commit message. This is important since some, like those from renovate, will be over the other tools 72 character limit.
tsloughter
force-pushed
the
ts/commitlintjs
branch
from
6c26e63 to
3e273a0
Compare
ferd
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to have some control over what is an allowed commit message. This is important since some, like those from renovate, will be over the other tools 72 character limit.