fix(chloggen): improve error handling in DeleteEntries#1568
Open
yoursanonymous wants to merge 2 commits intoopen-telemetry:mainfrom
Open
fix(chloggen): improve error handling in DeleteEntries#1568yoursanonymous wants to merge 2 commits intoopen-telemetry:mainfrom
yoursanonymous wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, the DeleteEntries function in the chloggen tool would print deletion failures directly to stdout and return nil. This behavior bypassed the command's error-handling system, making it appear that the operation was successful even if it failed to clean up temporary entry files.
Changes: