otelconf: Increased test coverage for Prometheus-related code #7440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7440 +/- ##
=====================================
Coverage 78.7% 78.8%
=====================================
Files 186 186
Lines 14694 14701 +7
=====================================
+ Hits 11571 11587 +16
+ Misses 2782 2775 -7
+ Partials 341 339 -2 🚀 New features to boost your workflow:
|
pellared
reviewed
Jun 9, 2025
dmathieu
added
the
Skip Changelog
pellared
reviewed
Jun 30, 2025
pellared
reviewed
Jun 30, 2025
|
@sonalgaud12, are you able to address the comments? |
pellared
reviewed
Jul 31, 2025
MrAlias
reviewed
Jul 31, 2025
pellared
approved these changes
Aug 4, 2025
MrAlias
reviewed
Aug 4, 2025
Co-authored-by: Tyler Yahn <[email protected]>
XSAM
reviewed
Aug 12, 2025
| // localhost resolves to 127.0.0.1, so we expect the resolved IP | ||
| assert.Contains(t, addr, "127.0.0.1") | ||
|
|
||
| resp, err := http.DefaultClient.Get("http://" + addr + "/metrics") |
There was a problem hiding this comment.
Suggested change
| resp, err := http.DefaultClient.Get("http://" + addr + "/metrics") | |
| resp, err := http.Get("http://" + addr + "/metrics") |
nit, as some of your tests use http.Get
| } | ||
| } | ||
|
|
||
| func TestPrometheusReaderErrorCases(t *testing.T) { |
There was a problem hiding this comment.
Could we use a table-driven approach? Just like the other TestPrometheusReaderErrorCases method you wrote?
|
@sonalgaud12, are you able to address @XSAM's comments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #6821
Added test for prometheusReader function for both v0.3.0 & v0.2.0
Locally tested