Honor otelhttp.WithMessageEvents(otelhttp.ReadEvents) option with otelhttp.NewTransport(...) #7513
+88
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lhttp.NewTransport(...)
dmathieu
reviewed
Jun 30, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7513 +/- ##
=====================================
Coverage 81.5% 81.6%
=====================================
Files 200 200
Lines 18129 18133 +4
=====================================
+ Hits 14793 14803 +10
+ Misses 2938 2932 -6
Partials 398 398
🚀 New features to boost your workflow:
|
dmathieu
reviewed
Jun 30, 2025
|
The linter is now failing :) |
dmathieu
reviewed
Jul 15, 2025
Co-authored-by: Damien Mathieu <[email protected]>
dmathieu
approved these changes
Jul 17, 2025
pellared
reviewed
Jul 17, 2025
Comment on lines
+652
to
+654
| if len(spans) != 1 { | ||
| t.Fatalf("expected 1 span; got: %d", len(spans)) | ||
| } |
There was a problem hiding this comment.
Can we use `require.Len`` instead?
Comment on lines
+640
to
+642
| if err != nil { | ||
| t.Fatal(err) | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My primary goal is for http client requests to trace time-to-first-response-byte, and there is very likely a much more efficient method to capture just this detail. The time to the first response byte is important for large streaming responses where it is far less helpful to record only the moment after the entire response body has been completely read.
However, using the existing pattern established by
otelhttp.NewHandler(..., otelhttp.WithMessageEvents(otelhttp.ReadEvents))for http server requests and extending it to also work withotelhttp.NewTransportthe same information (and more) becomes available for a very small code change and no API change.I looked for existing tests for Handler and WithMessageEvents to replicate to Transport but did not find any so I'm not sure what the preferred pattern would be for adding unit tests for this functionality.