-
Notifications
You must be signed in to change notification settings - Fork 702
Support text interchange with minsev severity
#7652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7652 +/- ##
=======================================
+ Coverage 78.7% 78.9% +0.1%
=======================================
Files 186 186
Lines 14702 14819 +117
=======================================
+ Hits 11582 11699 +117
Misses 2780 2780
Partials 340 340
🚀 New features to boost your workflow:
|
2db2ae9 to
ba650f2
Compare
minsev severity
sahidvelji
reviewed
Aug 3, 2025
Contributor
sahidvelji
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid PR. Thank you! Left a few minor comments.
Co-authored-by: Sahid Velji <[email protected]>
sahidvelji
approved these changes
Aug 4, 2025
pellared
reviewed
Aug 5, 2025
Co-authored-by: Robert Pająk <[email protected]>
pellared
approved these changes
Aug 5, 2025
Co-authored-by: Robert Pająk <[email protected]>
sahidvelji
reviewed
Aug 6, 2025
sahidvelji
approved these changes
Aug 6, 2025
Co-authored-by: Sahid Velji <[email protected]>
XSAM
approved these changes
Aug 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7576
Changes
SeverityStringmethod to implementfmt.StringerMarshalTextmethod to implementencoding.TextMarshalerUnmarshalTextmethod to implementencoding.TextUnmarshalerAppendTextmethod to implementencoding.TextAppenderMarshalJSONmethod to implementjson.MarshalerUnmarshalJSONmethod to implementjson.UnmarshalerSeverityVar
Stringmethod to implementfmt.StringerMarshalTextmethod to implementencoding.TextMarshalerUnmarshalTextmethod to implementencoding.TextUnmarshalerAppendTextmethod to implementencoding.TextAppenderTests