-
Notifications
You must be signed in to change notification settings - Fork 692
chore: enable exposedSyncMutex rule from go-critic #7726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mmorel-35
wants to merge
16
commits into
open-telemetry:main
Choose a base branch
from
mmorel-35:gocritic/exposedSyncMutex
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
8530472
chore: enable exposedSyncMutex rule from go-critic
mmorel-35 6fedb8f
Expose mutex methods and deprecate their uses
mmorel-35 c3c5d58
Apply suggestions from code review
mmorel-35 9f63fc3
update CHANGELOG
mmorel-35 2238e3b
make Mutex interfaces noop
mmorel-35 1b19815
Merge branch 'main' into gocritic/exposedSyncMutex
pellared 46aa08a
Update CHANGELOG with deprecations and removals
mmorel-35 c91a6e2
Deprecate mutex exposure and suggest alternatives
mmorel-35 f6c8f02
Add deprecated mutex to IDGenerator struct
mmorel-35 0a4fb75
Add deprecated mutex to perOperationSampler
mmorel-35 e0fe00d
Add comment for ongoing deletion in sampler.go
mmorel-35 bc456c2
Remove deprecated mutex comment in sampler.go
mmorel-35 a794cea
Deprecate internal mutex in Sampler struct
mmorel-35 84c9b64
Update propagators/aws/xray/idgenerator.go
mmorel-35 d0061c7
Add mutex field to IDGenerator struct
mmorel-35 2cf8caa
Merge branch 'main' into gocritic/exposedSyncMutex
mmorel-35 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.