Fix EKS detector container ID parsing for Kubernetes/containerd #7786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated containerIDRegex to support both Docker and Kubernetes cgroup formats - Modified getContainerID() to properly extract container ID from regex capture groups - Fixes issue where EKS detector fails with 'cannot read containerID from file /proc/self/cgroup' - Now supports cgroup paths like /kubepods/burstable/pod<pod-id>/<container-id>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7786 +/- ##
=======================================
- Coverage 78.9% 78.9% -0.1%
=======================================
Files 186 186
Lines 14819 14824 +5
=======================================
- Hits 11705 11699 -6
- Misses 2776 2785 +9
- Partials 338 340 +2
🚀 New features to boost your workflow:
|
dmathieu
reviewed
Aug 26, 2025
|
|
||
| // is this going to stop working with 1.20 when Docker is deprecated? | ||
| var containerIDRegex = regexp.MustCompile(`^.*/docker/(.+)$`) | ||
| // Updated regex to support both Docker and Kubernetes/containerd cgroup formats |
There was a problem hiding this comment.
Comments shouldn't be about things that have been updated (GIT has history for that), but actual issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error I had encountered