Skip to content

Conversation

@dashpole
Copy link
Contributor

@dashpole dashpole commented Mar 4, 2025

I would like to be able to use a private option in #6393 in tests, and decided to split this refactoring out into its own PR.

This moves the batch span processor benchmarks into benchmark_test.go, and replaces one instance of the tracetest.NewInMemoryExporter with a different test exporter implementation. It then moves most unit tests from trace_test to the main trace package.

@dashpole dashpole added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 4, 2025
@codecov
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.8%. Comparing base (38f4f39) to head (094ba27).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #6400     +/-   ##
=======================================
- Coverage   81.9%   81.8%   -0.1%     
=======================================
  Files        283     283             
  Lines      24899   24899             
=======================================
- Hits       20395   20379     -16     
- Misses      4101    4117     +16     
  Partials     403     403             

see 5 files with indirect coverage changes

@dashpole dashpole merged commit e2aee3a into open-telemetry:main Mar 5, 2025
39 checks passed
@dashpole dashpole deleted the change_testing branch March 5, 2025 02:29
@XSAM XSAM added this to the v1.35.0 milestone Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants