sdk/trace: self-observability: span metrics #7027

pellared · 2025-07-15T13:24:39Z

Implement following self-observability metrics from https://github.com/open-telemetry/semantic-conventions/blob/v1.36.0/docs/otel/sdk-metrics.md for https://pkg.go.dev/go.opentelemetry.io/otel/sdk/trace:

otel.sdk.span.live
otel.sdk.span.started

codecov · 2025-07-15T13:26:22Z

Codecov Report

Attention: Patch coverage is 89.88764% with 9 lines in your changes missing coverage. Please review.

Project coverage is 82.9%. Comparing base (3e440ba) to head (ad13ce9).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
sdk/trace/tracer.go	88.2%	4 Missing and 2 partials ⚠️
sdk/trace/span.go	75.0%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #7027   +/-   ##
=====================================
  Coverage   82.8%   82.9%           
=====================================
  Files        261     262    +1     
  Lines      24371   24460   +89     
=====================================
+ Hits       20200   20281   +81     
- Misses      3796    3801    +5     
- Partials     375     378    +3

Files with missing lines	Coverage Δ
sdk/trace/internal/x/x.go	`100.0% <100.0%> (ø)`
sdk/trace/provider.go	`85.3% <100.0%> (+<0.1%)`	⬆️
sdk/trace/span.go	`84.8% <75.0%> (-0.3%)`	⬇️
sdk/trace/tracer.go	`95.9% <88.2%> (-4.1%)`	⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sdk/trace/doc.go

sdk/trace/tracer.go

pellared · 2025-07-16T13:07:23Z

@dashpole, can you make an initial review?
For sure it would be good to increase the code coverage to test different values of otel.span.sampling_result attribute.
Maybe have some proposals to refactor the implementation? I would rather want it simple so that the sub-issues of #7003 could be good first issue.

sdk/trace/span.go

sdk/trace/trace_test.go

sdk/trace/tracer.go

sdk/trace/provider.go

sdk/trace/internal/x/README.md

Co-authored-by: Damien Mathieu <[email protected]>

pellared · 2025-07-21T09:37:04Z

@open-telemetry/go-maintainers, I plan to merge this tomorrow in order to give one more day for reviewers.

sdk/trace/internal/x/x.go

sdk/trace/tracer.go

pellared · 2025-07-22T09:35:45Z

Merging to unblock #6393

This release is the last to support [Go 1.23]. The next release will require at least [Go 1.24]. ### Added - Add native histogram exemplar support in `go.opentelemetry.io/otel/exporters/prometheus`. (#6772) - Add template attribute functions to the `go.opentelmetry.io/otel/semconv/v1.34.0` package. (#6939) - `ContainerLabel` - `DBOperationParameter` - `DBSystemParameter` - `HTTPRequestHeader` - `HTTPResponseHeader` - `K8SCronJobAnnotation` - `K8SCronJobLabel` - `K8SDaemonSetAnnotation` - `K8SDaemonSetLabel` - `K8SDeploymentAnnotation` - `K8SDeploymentLabel` - `K8SJobAnnotation` - `K8SJobLabel` - `K8SNamespaceAnnotation` - `K8SNamespaceLabel` - `K8SNodeAnnotation` - `K8SNodeLabel` - `K8SPodAnnotation` - `K8SPodLabel` - `K8SReplicaSetAnnotation` - `K8SReplicaSetLabel` - `K8SStatefulSetAnnotation` - `K8SStatefulSetLabel` - `ProcessEnvironmentVariable` - `RPCConnectRPCRequestMetadata` - `RPCConnectRPCResponseMetadata` - `RPCGRPCRequestMetadata` - `RPCGRPCResponseMetadata` - Add `ErrorType` attribute helper function to the `go.opentelmetry.io/otel/semconv/v1.34.0` package. (#6962) - Add `WithAllowKeyDuplication` in `go.opentelemetry.io/otel/sdk/log` which can be used to disable deduplication for log records. (#6968) - Add `WithCardinalityLimit` option to configure the cardinality limit in `go.opentelemetry.io/otel/sdk/metric`. (#6996, #7065, #7081, #7164, #7165, #7179) - Add `Clone` method to `Record` in `go.opentelemetry.io/otel/log` that returns a copy of the record with no shared state. (#7001) - Add experimental self-observability span and batch span processor metrics in `go.opentelemetry.io/otel/sdk/trace`. Check the `go.opentelemetry.io/otel/sdk/trace/internal/x` package documentation for more information. (#7027, #6393, #7209) - The `go.opentelemetry.io/otel/semconv/v1.36.0` package. The package contains semantic conventions from the `v1.36.0` version of the OpenTelemetry Semantic Conventions. See the [migration documentation](./semconv/v1.36.0/MIGRATION.md) for information on how to upgrade from `go.opentelemetry.io/otel/semconv/v1.34.0.`(#7032, #7041) - Add support for configuring Prometheus name translation using `WithTranslationStrategy` option in `go.opentelemetry.io/otel/exporters/prometheus`. The current default translation strategy when UTF-8 mode is enabled is `NoUTF8EscapingWithSuffixes`, but a future release will change the default strategy to `UnderscoreEscapingWithSuffixes` for compliance with the specification. (#7111) - Add experimental self-observability log metrics in `go.opentelemetry.io/otel/sdk/log`. Check the `go.opentelemetry.io/otel/sdk/log/internal/x` package documentation for more information. (#7121) - Add experimental self-observability trace exporter metrics in `go.opentelemetry.io/otel/exporters/stdout/stdouttrace`. Check the `go.opentelemetry.io/otel/exporters/stdout/stdouttrace/internal/x` package documentation for more information. (#7133) - Support testing of [Go 1.25]. (#7187) - The `go.opentelemetry.io/otel/semconv/v1.37.0` package. The package contains semantic conventions from the `v1.37.0` version of the OpenTelemetry Semantic Conventions. See the [migration documentation](./semconv/v1.37.0/MIGRATION.md) for information on how to upgrade from `go.opentelemetry.io/otel/semconv/v1.36.0.`(#7254) ### Changed - Optimize `TraceIDFromHex` and `SpanIDFromHex` in `go.opentelemetry.io/otel/sdk/trace`. (#6791) - Change `AssertEqual` in `go.opentelemetry.io/otel/log/logtest` to accept `TestingT` in order to support benchmarks and fuzz tests. (#6908) - Change `DefaultExemplarReservoirProviderSelector` in `go.opentelemetry.io/otel/sdk/metric` to use `runtime.GOMAXPROCS(0)` instead of `runtime.NumCPU()` for the `FixedSizeReservoirProvider` default size. (#7094) ### Fixed - `SetBody` method of `Record` in `go.opentelemetry.io/otel/sdk/log` now deduplicates key-value collections (`log.Value` of `log.KindMap` from `go.opentelemetry.io/otel/log`). (#7002) - Fix `go.opentelemetry.io/otel/exporters/prometheus` to not append a suffix if it's already present in metric name. (#7088) - Fix the `go.opentelemetry.io/otel/exporters/stdout/stdouttrace` self-observability component type and name. (#7195) - Fix partial export count metric in `go.opentelemetry.io/otel/exporters/stdout/stdouttrace`. (#7199) ### Deprecated - Deprecate `WithoutUnits` and `WithoutCounterSuffixes` options, preferring `WithTranslationStrategy` instead. (#7111) - Deprecate support for `OTEL_GO_X_CARDINALITY_LIMIT` environment variable in `go.opentelemetry.io/otel/sdk/metric`. Use `WithCardinalityLimit` option instead. (#7166)

add docs

3eeba4c

Refine docs

5fe199b

pellared commented Jul 15, 2025

View reviewed changes

sdk/trace/doc.go Outdated Show resolved Hide resolved

This was referenced Jul 15, 2025

Trace SDK observability - stdouttrace exporter metrics #7008

Closed

Logs SDK observability - stdoutlog exporter metrics #7020

Open

pellared added 11 commits July 16, 2025 12:36

Merge branch 'main' into span-metrics

2212cb2

Move experimental docs to x/internal

16df7b8

improve docs

e6a3029

update header

45aaace

fix link

7c1ea5c

draft implementation

547a989

add TestSelfObservabilty and fix implementation

bb6b8f8

Add attributes

2fd1368

Add changelog entry

25894d6

lint

418297e

Update TODO comments

6b33d72

pellared commented Jul 16, 2025

View reviewed changes

sdk/trace/tracer.go Show resolved Hide resolved

pellared mentioned this pull request Jul 16, 2025

Generate semconv/v1.36.0 #7032

Merged

pellared requested a review from dashpole July 16, 2025 13:08

dashpole reviewed Jul 16, 2025

View reviewed changes

sdk/trace/span.go Outdated Show resolved Hide resolved

dashpole reviewed Jul 16, 2025

View reviewed changes

sdk/trace/span.go Outdated Show resolved Hide resolved

sdk/trace/trace_test.go Outdated Show resolved Hide resolved

sdk/trace/tracer.go Show resolved Hide resolved

sdk/trace/tracer.go Outdated Show resolved Hide resolved

dashpole reviewed Jul 16, 2025

View reviewed changes

sdk/trace/provider.go Outdated Show resolved Hide resolved

pellared added 6 commits July 17, 2025 16:31

Merge branch 'main' into span-metrics

d9105c0

go mod tidy

3d132c7

Bump to semconv/v1.36.0

713a3e7

refactor initSelfObservability

8cd9767

refactor attr creation

6304e1d

add otel.span.parent.origin attribute

3fa8aa5

Merge branch 'main' into span-metrics

76001a3

dmathieu approved these changes Jul 21, 2025

View reviewed changes

sdk/trace/internal/x/README.md Outdated Show resolved Hide resolved

Update sdk/trace/internal/x/README.md

5e44856

Co-authored-by: Damien Mathieu <[email protected]>

XSAM reviewed Jul 21, 2025

View reviewed changes

sdk/trace/internal/x/x.go Show resolved Hide resolved

sdk/trace/tracer.go Outdated Show resolved Hide resolved

Merge branch 'main' into span-metrics

afee3cc

pellared mentioned this pull request Jul 22, 2025

Improve Go doc comments for functions returning bool #7063

Closed

refactor: reuse x.SelfObservability

ad13ce9

pellared requested a review from XSAM July 22, 2025 09:28

pellared merged commit 186def7 into open-telemetry:main Jul 22, 2025
32 checks passed

pellared deleted the span-metrics branch July 22, 2025 09:40

MrAlias added this to the v1.38.0 milestone Aug 20, 2025

MrAlias mentioned this pull request Aug 29, 2025

Release v1.38.0 #7271

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

sdk/trace: self-observability: span metrics #7027

sdk/trace: self-observability: span metrics #7027

Uh oh!

pellared commented Jul 15, 2025 •

edited

Loading

Uh oh!

codecov bot commented Jul 15, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

pellared commented Jul 16, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pellared commented Jul 21, 2025

Uh oh!

Uh oh!

Uh oh!

pellared commented Jul 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sdk/trace: self-observability: span metrics #7027

sdk/trace: self-observability: span metrics #7027

Uh oh!

Conversation

pellared commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

pellared commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pellared commented Jul 21, 2025

Uh oh!

Uh oh!

Uh oh!

pellared commented Jul 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pellared commented Jul 15, 2025 •

edited

Loading

codecov bot commented Jul 15, 2025 •

edited

Loading

pellared commented Jul 16, 2025 •

edited

Loading