-
Notifications
You must be signed in to change notification settings - Fork 1.2k
sdk/log: self-observability: simple processor metrics #7127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
sdk/log: self-observability: simple processor metrics #7127
Conversation
this is not what this PR is doing 😉 |
otel.sdk.log.created
metricotel.sdk.processor.log.processed
metric
@pellared, |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7127 +/- ##
=====================================
Coverage 82.9% 82.9%
=====================================
Files 265 265
Lines 24894 24926 +32
=====================================
+ Hits 20643 20673 +30
- Misses 3876 3878 +2
Partials 375 375
🚀 New features to boost your workflow:
|
d2e9e4e
to
cd36d4b
Compare
Additionally: Please add a CHANGELOG. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor tweaks are needed, thank you for your contribution.
…metry#7016) Implements `otel.sdk.processor.log.processed` as defined in the semantic conventions.
…unter Co-authored-by: Flc゛ <[email protected]>
Remove redundant t.SetEnv call as undefined and empty environment variables have identical behavior in the Selfobervability.Enabled() logic.
56cd0fd
to
c460385
Compare
Really appreciate your quick and helpful feedback! |
@hostejulien, from https://github.com/open-telemetry/opentelemetry-go/blob/main/CONTRIBUTING.md:
|
@pellared, Got it. Thanks for the heads up! |
otel.sdk.processor.log.processed
metric
@hostejulien PTAL #7272 |
Hi, since this process involves specification adjustments and historical review records (which may contain invalid review suggestions), it’s impossible to tell which items need attention amid the large volume of information. Could we create a new PR based on the current branch before preparing for the review, so that subsequent reviews can proceed more smoothly? Thanks~ |
@hostejulien please take a look at #7016. I have updated the issue with a check list of items from our project Observability guidelines that need to be completed in this PR. As @flc1125 pointed out, you may find it easier to open a new PR. But feel free to update this PR as well. If you plan to update this PR, please mark it as a draft while you are working to address the items listed in #7016 and the Observability guidelines. |
@hostejulien I just wanted to check in with this PR. Are you still able to update this PR or open a new PR to address the instrumentation requirements? |
Fixes #7016
This PR adds support for the experimental
otel.sdk.processor.log.processed
metric, emitted when a logger is created via the SDK. This metric follows the OpenTelemetry semantic conventions for SDK metrics.As the feature is experimental, emission is gated behind the OTEL_GO_X_SELF_OBSERVABILITY environment variable. When set to any case-insensitive value of true, metrics will be recorded.