Skip to content

sdk/log: Fix AddAttributes, SetAttributes, SetBody on Record to not mutate input #7403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
Oct 16, 2025
+722 −74
Merged

sdk/log: Fix AddAttributes, SetAttributes, SetBody on Record to not mutate input #7403

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
35e2dd6
Remove Skip fromTestRecordMethodsInputConcurrentSafe
pellared Sep 23, 2025
b70173b
Fix AddAttributes, SetAttributes, SetBody to not mutate the input
pellared Sep 23, 2025
77e28ee
add missing dot
pellared Sep 23, 2025
66f2a61
Use sync.Pool for seen maps
pellared Sep 23, 2025
97ddd07
remove unused race function
pellared Sep 23, 2025
33db499
Add changelog entry
pellared Sep 23, 2025
40412d1
add dots
pellared Sep 23, 2025
defde16
add missing dot
pellared Sep 23, 2025
25cd8f8
limits should only take effect when the value is not negative
pellared Sep 23, 2025
9976991
Faster pool resource return
pellared Sep 23, 2025
bd9150f
Faster pool resource return cont
pellared Sep 23, 2025
efa0d94
Add missing test cases
pellared Sep 23, 2025
46b17f1
Merge branch 'main' into fix-7364
pellared Sep 24, 2025
38d0acd
Merge branch 'main' into fix-7364
pellared Sep 24, 2025
1edfb29
Merge branch 'main' into fix-7364
pellared Sep 25, 2025
88ff4f3
Merge branch 'main' into fix-7364
pellared Sep 25, 2025
27bdafe
addAttrs to applyAttrLimitsAndDedup after slices.Grow
pellared Sep 25, 2025
d76cdaf
add TestRecordAddAttributesDoesNotMutateInput
pellared Sep 25, 2025
4341fd4
more iterative code to ease readability and debugging
pellared Sep 25, 2025
e4604ac
use map[string]struct{} for seenPool to reduce memory usage
pellared Sep 25, 2025
037899d
Merge branch 'main' into fix-7364
pellared Sep 25, 2025
78f60ba
Merge branch 'main' into fix-7364
pellared Sep 25, 2025
e46f447
Merge branch 'main' into fix-7364
pellared Sep 26, 2025
55a702d
Merge branch 'main' into fix-7364
pellared Sep 29, 2025
b43ad7b
Merge branch 'main' into fix-7364
pellared Sep 29, 2025
ca7fa97
Merge branch 'main' into fix-7364
pellared Sep 30, 2025
2547a7a
Merge branch 'main' into fix-7364
pellared Oct 1, 2025
3b67370
dedup func with single iteration
pellared Oct 1, 2025
9084386
improve comments
pellared Oct 1, 2025
d199ebe
improve comments and pool
pellared Oct 1, 2025
60be936
AddAttributes func with single iteration
pellared Oct 1, 2025
faf2bcd
Merge branch 'main' into fix-7364
pellared Oct 2, 2025
ec872a5
Merge branch 'main' into fix-7364
pellared Oct 3, 2025
7d85713
Merge branch 'main' into fix-7364
pellared Oct 8, 2025
67efe02
Merge branch 'main' into fix-7364
pellared Oct 14, 2025
4e5e8a5
Merge branch 'main' into fix-7364
pellared Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
- Return partial OTLP export errors to the caller in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp`. (#7372)
- Return partial OTLP export errors to the caller in `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc`. (#7372)
- Return partial OTLP export errors to the caller in `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp`. (#7372)
- Fix `AddAttributes`, `SetAttributes`, `SetBody` on `Record` in `go.opentelemetry.io/otel/sdk/log` to not mutate input. (#7403)

### Removed

Expand Down
11 changes: 0 additions & 11 deletions sdk/log/race_off_test.go
View file
Open in desktop

This file was deleted.

11 changes: 0 additions & 11 deletions sdk/log/race_on_test.go
View file
Open in desktop

This file was deleted.

Loading
Loading