chore: sdk/metric/internal/x - generate x package from x component template (#7386) #7430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ternua8
requested review from
MrAlias,
XSAM,
dashpole,
dmathieu,
flc1125 and
pellared
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7430 +/- ##
=====================================
Coverage 86.1% 86.2%
=====================================
Files 291 291
Lines 25615 25620 +5
=====================================
+ Hits 22059 22086 +27
+ Misses 3183 3162 -21
+ Partials 373 372 -1
🚀 New features to boost your workflow:
|
|
Is there a tracking issue for EnabledInstrument? |
|
@ternua8 it looks like the linter is failing. Please run |
MrAlias
reviewed
Sep 30, 2025
| @@ -0,0 +1,12 @@ | |||
| package x | |||
There was a problem hiding this comment.
Suggested change
| package x | |
| // Copyright The OpenTelemetry Authors | |
| // SPDX-License-Identifier: Apache-2.0 | |
| package x |
|
@ternua8 are you still able to work on this? |
|
Hey, just returned from vacation — I can pick this up again! |
ternua8
force-pushed
the
metric-x-template
branch
from
a48c48e to
0afbbf1
Compare
ternua8
force-pushed
the
metric-x-template
branch
from
0afbbf1 to
d9451fb
Compare
ternua8
force-pushed
the
metric-x-template
branch
from
d9451fb to
071f8c8
Compare
flc1125
reviewed
Oct 14, 2025
| import "context" | ||
|
|
||
| // EnabledInstrument interface is implemented by synchronous instruments. | ||
| type EnabledInstrument interface { |
There was a problem hiding this comment.
Can we keep the original comments?
| ctx := t.Context() | ||
| enabled := ei.Enabled(ctx) | ||
|
|
||
| require.True(t, enabled, "Enabled() should return true") |
There was a problem hiding this comment.
Perhaps using assert.Implements(....) would be more appropriate.
MrAlias
reviewed
Oct 14, 2025
|
|
||
| import "context" | ||
|
|
||
| // EnabledInstrument interface is implemented by synchronous instruments. |
There was a problem hiding this comment.
Suggested change
| // EnabledInstrument interface is implemented by synchronous instruments. | |
| // EnabledInstrument informs whether the instrument is enabled. | |
| // | |
| // EnabledInstrument interface is implemented by synchronous instruments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Switch the metric
xpackage to template-based generation, similar to trace.Add the
EnabledInstrumentinterface in a separate file for synchronous instruments.Details
sdk/metric/internal/x/gen.gouses the sharedx.go.tmplto generatex.goandx_test.go.EnabledInstrumentinterface is added inenabled_instrument.goto allow instruments to report if they are enabled.enabled_instrument_test.go.Notes
newFeaturefunction generated by the template is currently unused in metric, but it is kept for consistency with trace.