-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add temporality selector functions #7434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, please ignore. That was the wrong tab 🤦 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7434 +/- ##
=======================================
- Coverage 85.5% 85.5% -0.1%
=======================================
Files 279 279
Lines 24725 24711 -14
=======================================
- Hits 21158 21146 -12
+ Misses 3188 3186 -2
Partials 379 379
🚀 New features to boost your workflow:
|
MrAlias
approved these changes
Sep 30, 2025
Please add a changelog entry and tests to cover the added functionality. |
Do we want a change log for this? |
Yes, please. |
dashpole
approved these changes
Oct 1, 2025
included tests and a changelog |
dmathieu
reviewed
Oct 1, 2025
Co-authored-by: Damien Mathieu <[email protected]>
dmathieu
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From: #7346
This PR exposes the default TemporalitySelector funcs that are used by the OTel env var processing.
The reason to expose these funcs is because there is some discrepancy in various vendor documentation on how to enable these settings using go option args WithTemporalitySelector
https://cloud-native.slack.com/archives/C01NPAXACKT/p1757443233624599