Skip to content

Conversation

dprotaso
Copy link
Contributor

@dprotaso dprotaso commented Sep 30, 2025

From: #7346

This PR exposes the default TemporalitySelector funcs that are used by the OTel env var processing.

The reason to expose these funcs is because there is some discrepancy in various vendor documentation on how to enable these settings using go option args WithTemporalitySelector

https://cloud-native.slack.com/archives/C01NPAXACKT/p1757443233624599

MrAlias

This comment was marked as outdated.

@dprotaso

This comment was marked as outdated.

@MrAlias MrAlias self-requested a review September 30, 2025 20:59
@MrAlias
Copy link
Contributor

MrAlias commented Sep 30, 2025

Sorry, please ignore. That was the wrong tab 🤦

Copy link

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.5%. Comparing base (ffeeee8) to head (44e5a13).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #7434     +/-   ##
=======================================
- Coverage   85.5%   85.5%   -0.1%     
=======================================
  Files        279     279             
  Lines      24725   24711     -14     
=======================================
- Hits       21158   21146     -12     
+ Misses      3188    3186      -2     
  Partials     379     379             
Files with missing lines Coverage Δ
...pmetric/otlpmetricgrpc/internal/oconf/envconfig.go 96.8% <100.0%> (-0.4%) ⬇️
...pmetric/otlpmetrichttp/internal/oconf/envconfig.go 96.8% <100.0%> (-0.4%) ⬇️
sdk/metric/reader.go 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MrAlias
Copy link
Contributor

MrAlias commented Sep 30, 2025

Please add a changelog entry and tests to cover the added functionality.

@dprotaso
Copy link
Contributor Author

Do we want a change log for this?

@MrAlias MrAlias self-requested a review September 30, 2025 21:01
@dmathieu
Copy link
Member

dmathieu commented Oct 1, 2025

Do we want a change log for this?

Yes, please.

@dprotaso
Copy link
Contributor Author

dprotaso commented Oct 1, 2025

included tests and a changelog

Co-authored-by: Damien Mathieu <[email protected]>
@MrAlias MrAlias changed the title refactor out temporality selector funcs Add temporality selector functions Oct 1, 2025
@dmathieu dmathieu merged commit dee11e6 into open-telemetry:main Oct 2, 2025
32 checks passed
@dprotaso dprotaso deleted the temporality-funcs branch October 2, 2025 14:37
@MrAlias MrAlias added this to the v1.39.0 milestone Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants