-
Notifications
You must be signed in to change notification settings - Fork 1.2k
stdoutmetric: self-observability: exporter metrics #7492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mahendrabishnoi2
wants to merge
52
commits into
open-telemetry:main
Choose a base branch
from
mahendrabishnoi2:stdoutmetric-auto-instrumentation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,026
−4
Open
Changes from all commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
48b1568
copied code with minor modifications for docs and feature flag: OTEL_…
mahendrabishnoi2 c03b9f0
Merge branch 'main' into stdoutmetric-auto-instrumentation
mahendrabishnoi2 4ddd0b3
Merge branch 'main' into stdoutmetric-auto-instrumentation
mahendrabishnoi2 987b77e
added self-observability support to stdoutmetric exporter for below m…
mahendrabishnoi2 b4d2756
fixed broken link
mahendrabishnoi2 b7181a4
added changelog entry for self-observability support in stdoutmetric …
mahendrabishnoi2 c6f91ac
run `make precommit`
mahendrabishnoi2 a9ad0e2
fix a bug where attributes defined in ExporterMetrics are mutated
mahendrabishnoi2 7b1fb2d
test cases for ExporterMetrics
mahendrabishnoi2 ef4a629
test cases for stdoutmetric exporter
mahendrabishnoi2 51f2f2b
Merge branch 'main' into stdoutmetric-auto-instrumentation
mahendrabishnoi2 38eb316
remove unused receiver to make linter (unused-receiver) happy
mahendrabishnoi2 b67b593
fix version
mahendrabishnoi2 ecbb337
fix version
mahendrabishnoi2 d6d0dd8
make stdoutMetricExporterComponentType as constant
mahendrabishnoi2 ee64105
Use defer to call trackExportFunc, Thanks to @flc1125
mahendrabishnoi2 ddfb3c3
duration -> durationSeconds
mahendrabishnoi2 db64dc0
Merge branch 'main' into stdoutmetric-auto-instrumentation
mahendrabishnoi2 089252e
suppress linter as err is used in defer statement
mahendrabishnoi2 884ade7
instead of suppressing error, split if and err check on 2 lines
mahendrabishnoi2 32b6f61
Merge branch 'main' into stdoutmetric-auto-instrumentation
pellared 460f303
addressed review comment: use named return to make code more readable
mahendrabishnoi2 9fea018
Merge branch 'main' into stdoutmetric-auto-instrumentation
mahendrabishnoi2 a6f0637
name component similar to https://github.com/open-telemetry/opentelem…
mahendrabishnoi2 938cbb0
flatten the self-observability initialization and return the error to…
mahendrabishnoi2 b247192
Merge branch 'main' into stdoutmetric-auto-instrumentation
mahendrabishnoi2 ee0328e
Merge branch 'main' into stdoutmetric-auto-instrumentation
mahendrabishnoi2 4c357a9
address review comments
mahendrabishnoi2 2edfed9
address review comments
mahendrabishnoi2 18e0530
generate internal counter package so that it can be tested by resetti…
mahendrabishnoi2 9976cfc
review comments: improve tests, merge tests
mahendrabishnoi2 2f84c09
Run `make precommit`
mahendrabishnoi2 5dd37f2
Merge branch 'main' into stdoutmetric-auto-instrumentation
mahendrabishnoi2 1f1eb84
run `make precommit`
mahendrabishnoi2 51e48eb
fix CHANGELOG.md
mahendrabishnoi2 7f64c38
refactoring to accommodate auto generation of x.go, replace usages of…
mahendrabishnoi2 c106988
benchmark for TrackExport
mahendrabishnoi2 49c5c9a
use precomputed set for happy path, still not optimal 5 allocs/op
mahendrabishnoi2 1643d6d
happy path allocs reduced to 1/op, will fix the ugly code later
mahendrabishnoi2 3903f85
minor refactor
mahendrabishnoi2 7ede990
move feature flag part to observ package.
mahendrabishnoi2 d03013d
fix failing test cases
mahendrabishnoi2 5742661
`make precommit`
mahendrabishnoi2 a723bfe
rename to Instrumentation
mahendrabishnoi2 3ab2586
fix CHANGELOG.md
mahendrabishnoi2 e34443f
rename self observability to observability
mahendrabishnoi2 69c1612
make constants unexported
mahendrabishnoi2 6233067
helper for component name
mahendrabishnoi2 909bc47
update docs
mahendrabishnoi2 ff814ca
update docs
mahendrabishnoi2 325bda9
linter happy
mahendrabishnoi2 c540ab0
Merge branch 'main' into stdoutmetric-auto-instrumentation
mahendrabishnoi2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we can directly use the following approach without defining a function (even if not enabled, it still incurs overhead because it returns an empty anonymous function).