-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Instrument the otlpmetrichttp
exporter
#7493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7493 +/- ##
=======================================
+ Coverage 86.2% 86.3% +0.1%
=======================================
Files 295 299 +4
Lines 25864 26120 +256
=======================================
+ Hits 22307 22566 +259
+ Misses 3184 3180 -4
- Partials 373 374 +1
🚀 New features to boost your workflow:
|
51bf317
to
334b631
Compare
334b631
to
47a0cf0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall quality is very high. There are some minor issues.
Additionally, for the benchmarking part, can we provide before and after comparison data? |
For sure, please find benchmark results as below:
|
Please resolve the conflict. |
resolve: #7011
Benchmarks