Skip to content

Checked if Operation Enabled in otlptracehttp before performing operation #7881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
itssaharsh wants to merge 3 commits into
base: main
Choose a base branch
from
+20 −12
Open

Checked if Operation Enabled in otlptracehttp before performing operation #7881

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a7bb2a
commit
itssaharsh Feb 7, 2026
7d70da2
fix
itssaharsh Feb 9, 2026
66eec55
Merge branch 'open-telemetry:main' into otlph
itssaharsh Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions exporters/otlp/otlptrace/otlptracehttp/internal/observ/instrumentation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,10 +261,12 @@ func parseIP(ip string) string {
func (i *Instrumentation) ExportSpans(ctx context.Context, nSpans int) ExportOp {
start := time.Now()

addOpt := get[metric.AddOption](addOptPool)
defer put(addOptPool, addOpt)
*addOpt = append(*addOpt, i.addOpt)
i.inflightSpans.Add(ctx, int64(nSpans), *addOpt...)
if i.inflightSpans.Enabled(ctx) {
addOpt := get[metric.AddOption](addOptPool)
defer put(addOptPool, addOpt)
*addOpt = append(*addOpt, i.addOpt)
i.inflightSpans.Add(ctx, int64(nSpans), *addOpt...)
}

return ExportOp{
ctx: ctx,
Expand Down Expand Up @@ -295,11 +297,16 @@ type ExportOp struct {
// of successfully exported spans will be determined by inspecting the
// RejectedItems field of the PartialSuccess.
func (e ExportOp) End(err error, status int) {
if !e.inst.exportedSpans.Enabled(e.ctx) {
return
}
addOpt := get[metric.AddOption](addOptPool)
defer put(addOptPool, addOpt)
*addOpt = append(*addOpt, e.inst.addOpt)

e.inst.inflightSpans.Add(e.ctx, -e.nSpans, *addOpt...)
if e.inst.inflightSpans.Enabled(e.ctx) {
e.inst.inflightSpans.Add(e.ctx, -e.nSpans, *addOpt...)
}

success := successful(e.nSpans, err)
// Record successfully exported spans, even if the value is 0 which are
Expand Down
Loading