use mise file tasks

zeitlinger · zeitlinger · commit 004c4d528b09 · 2025-09-30T15:13:27.000+02:00
diff --git a/.github/workflows/reusable-link-check.yml b/.github/workflows/reusable-link-check.yml
@@ -23,17 +23,6 @@ jobs:
         run: mise run lint:local-links
 
       - name: Link check (modified files only)
-        if: github.event_name == 'pull_request'
-        # todo only if config did not change
-        env:
-          GITHUB_TOKEN: ${{ github.token }}
-        run: mise run lint:links-in-modified-file --base origin/${{ github.base_ref }} --head ${{ github.event.pull_request.head.sha }}
-
-# todo one stop commend for linting that also works locally: lint:modified-links
-
-      - name: Link check (all files)
-        # todo also if not PR but config changed
-        if: github.event_name != 'pull_request'
         env:
           GITHUB_TOKEN: ${{ github.token }}
-        run: mise run lint:links-if-config-changed
+        run: mise run lint:links-in-modified-file --base origin/${{ github.base_ref }} --head ${{ github.event.pull_request.head.sha }} --event ${{ github.event_name }}
diff --git a/.mise/tasks/lint/links-if-config-changed b/.mise/tasks/lint/links-if-config-changed
diff --git a/.mise/tasks/lint/links-in-modified-files b/.mise/tasks/lint/links-in-modified-files
@@ -1,28 +1,38 @@
 #!/usr/bin/env bash
 #MISE description="Lint links in modified files"
 
-set -ex
+set -e
 
 #USAGE flag "--base <base>" help="base branch to compare against" default="origin/main"
 #USAGE flag "--head <head>" help="head branch to compare against" default=""
+#USAGE flag "--event <event>" help="PR name" default="pull_request"
 
 if [ "$usage_head" == "''" ]; then
   usage_head=""
 fi
 
-# Using lychee's default extension filter here to match when it runs against all files
-# Note: --diff-filter=d filters out deleted files
-modified_files=$(git diff --name-only --diff-filter=d "$usage_base" $usage_head \
-                  | grep -E '\.(md|mkd|mdx|mdown|mdwn|mkdn|mkdown|markdown|html|htm|txt)$' \
-                  | tr '\n' ' ' || true)
-
 # Check if lychee config was modified
 config_modified=$(git diff --name-only --merge-base "$usage_base" $usage_head \
-                  | grep -E '^(\.github/config/lychee\.toml|mise\.toml)$' || true)
+                  | grep -E '^(\.github/config/lychee\.toml|.mise/tasks/lint|mise\.toml)$' || true)
 
-if [ -z "$modified_files" ] && [ -z "$config_modified" ] ; then
-  echo "No modified files and no config changes, skipping link linting."
+if [ -n "$config_modified" ] ; then
+  echo "config changes, checking all files."
+  mise run lint:links
+elif [ "$usage_event" != "pull_request" ] ; then
+  echo "Not a PR - skipping link linting."
   exit 0
+else
+  # Using lychee's default extension filter here to match when it runs against all files
+  # Note: --diff-filter=d filters out deleted files
+  modified_files=$(git diff --name-only --diff-filter=d "$usage_base" $usage_head \
+                    | grep -E '\.(md|mkd|mdx|mdown|mdwn|mkdn|mkdown|markdown|html|htm|txt)$' \
+                    | tr '\n' ' ' || true)
+
+  if [ -z "$modified_files" ]; then
+    echo "No modified files, skipping link linting."
+    exit 0
+  fi
+
+  mise run lint:links $modified_files
 fi
 
-mise run lint:links $modified_files
