Skip to content

Commit 3d64fc7

Browse files
committed
fix: failing tests
1 parent 7743a2e commit 3d64fc7

File tree

4 files changed

+15
-8
lines changed

4 files changed

+15
-8
lines changed

disk-buffering/src/main/java/io/opentelemetry/contrib/disk/buffering/internal/serialization/mapping/logs/LogRecordDataMapper.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,6 @@ public LogRecord mapToProto(LogRecordData source) {
4747
if (source.getBodyValue() != null) {
4848
logRecord.body(bodyToAnyValue(source.getBodyValue()));
4949
}
50-
if (source.getEventName() != null) {
51-
logRecord.event_name(source.getEventName());
52-
}
5350

5451
byte flags = source.getSpanContext().getTraceFlags().asByte();
5552
logRecord.flags(toUnsignedInt(flags));
@@ -67,6 +64,9 @@ private static void addExtrasToProtoBuilder(LogRecordData source, LogRecord.Buil
6764
target.trace_id(ByteStringMapper.getInstance().stringToProto(spanContext.getTraceId()));
6865
target.dropped_attributes_count(
6966
source.getTotalAttributeCount() - source.getAttributes().size());
67+
if (source.getEventName() != null) {
68+
target.event_name(source.getEventName());
69+
}
7070
}
7171

7272
public LogRecordData mapToSdk(
@@ -80,9 +80,6 @@ public LogRecordData mapToSdk(
8080
if (source.body != null) {
8181
logRecordData.setBodyValue(anyValueToBody(source.body));
8282
}
83-
if (source.event_name != null) {
84-
logRecordData.setEventName(source.event_name);
85-
}
8683

8784
addExtrasToSdkItemBuilder(source, logRecordData, resource, scopeInfo);
8885

@@ -105,6 +102,7 @@ private static void addExtrasToSdkItemBuilder(
105102
target.setTotalAttributeCount(source.dropped_attributes_count + attributes.size());
106103
target.setResource(resource);
107104
target.setInstrumentationScopeInfo(scopeInfo);
105+
target.setEventName(source.event_name);
108106
}
109107

110108
private static AnyValue bodyToAnyValue(Value<?> body) {

disk-buffering/src/test/java/io/opentelemetry/contrib/disk/buffering/internal/serialization/mapping/logs/ProtoLogsDataMapperTest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ class ProtoLogsDataMapperTest {
3737
.setTimestampEpochNanos(100L)
3838
.setObservedTimestampEpochNanos(200L)
3939
.setTotalAttributeCount(3)
40+
.setEventName("")
4041
.build();
4142

4243
private static final LogRecordData OTHER_LOG_RECORD =
@@ -51,6 +52,7 @@ class ProtoLogsDataMapperTest {
5152
.setTimestampEpochNanos(100L)
5253
.setObservedTimestampEpochNanos(200L)
5354
.setTotalAttributeCount(3)
55+
.setEventName("")
5456
.build();
5557

5658
private static final LogRecordData LOG_RECORD_WITH_DIFFERENT_SCOPE_SAME_RESOURCE =
@@ -65,6 +67,7 @@ class ProtoLogsDataMapperTest {
6567
.setTimestampEpochNanos(100L)
6668
.setObservedTimestampEpochNanos(200L)
6769
.setTotalAttributeCount(3)
70+
.setEventName("")
6871
.build();
6972

7073
private static final LogRecordData LOG_RECORD_WITH_DIFFERENT_RESOURCE =
@@ -79,6 +82,7 @@ class ProtoLogsDataMapperTest {
7982
.setTimestampEpochNanos(100L)
8083
.setObservedTimestampEpochNanos(200L)
8184
.setTotalAttributeCount(3)
85+
.setEventName("")
8286
.build();
8387

8488
private static final LogRecordData LOG_RECORD_WITH_EVENT_NAME =

disk-buffering/src/test/java/io/opentelemetry/contrib/disk/buffering/internal/serialization/serializers/LogRecordDataSerializerTest.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,10 @@ class LogRecordDataSerializerTest extends BaseSignalSerializerTest<LogRecordData
2828
.setTimestampEpochNanos(100L)
2929
.setObservedTimestampEpochNanos(200L)
3030
.setTotalAttributeCount(3)
31+
.setEventName("event")
3132
.build();
3233

33-
private static final LogRecordData LOG_RECORD_WITHOUT_SEVERITY_TEXT =
34+
private static final LogRecordData LOG_RECORD_WITHOUT_SEVERITY_OR_EVENT_NAME_TEXT =
3435
LogRecordDataImpl.builder()
3536
.setResource(TestData.RESOURCE_FULL)
3637
.setSpanContext(TestData.SPAN_CONTEXT)
@@ -42,11 +43,12 @@ class LogRecordDataSerializerTest extends BaseSignalSerializerTest<LogRecordData
4243
.setTimestampEpochNanos(100L)
4344
.setObservedTimestampEpochNanos(200L)
4445
.setTotalAttributeCount(3)
46+
.setEventName("")
4547
.build();
4648

4749
@Test
4850
void verifySerialization() {
49-
assertSerialization(LOG_RECORD, LOG_RECORD_WITHOUT_SEVERITY_TEXT);
51+
assertSerialization(LOG_RECORD, LOG_RECORD_WITHOUT_SEVERITY_OR_EVENT_NAME_TEXT);
5052
}
5153

5254
@Override

disk-buffering/src/test/java/io/opentelemetry/contrib/disk/buffering/internal/storage/files/ReadableFileTest.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ class ReadableFileTest {
5757
.setTimestampEpochNanos(100L)
5858
.setObservedTimestampEpochNanos(200L)
5959
.setTotalAttributeCount(3)
60+
.setEventName("")
6061
.build();
6162

6263
private static final LogRecordData SECOND_LOG_RECORD =
@@ -71,6 +72,7 @@ class ReadableFileTest {
7172
.setTimestampEpochNanos(100L)
7273
.setObservedTimestampEpochNanos(200L)
7374
.setTotalAttributeCount(3)
75+
.setEventName("event")
7476
.build();
7577

7678
private static final LogRecordData THIRD_LOG_RECORD =
@@ -85,6 +87,7 @@ class ReadableFileTest {
8587
.setTimestampEpochNanos(100L)
8688
.setObservedTimestampEpochNanos(200L)
8789
.setTotalAttributeCount(3)
90+
.setEventName("")
8891
.build();
8992

9093
@BeforeEach

0 commit comments

Comments
 (0)