log export interval and simplify a bit config further

Author: SylvainJuge

jmx-scraper/src/integrationTest/java/io/opentelemetry/contrib/jmxscraper/JmxScraperContainer.java

@@ -24,7 +24,6 @@ public class JmxScraperContainer extends GenericContainer<JmxScraperContainer> {
   private final String endpoint;
   private final Set<String> targetSystems;
   private String serviceUrl;
-  private int intervalMillis;
   private final Set<String> customYamlFiles;
   private String user;
   private String password;
@@ -44,7 +43,6 @@ public JmxScraperContainer(String otlpEndpoint, String baseImage) {
     this.endpoint = otlpEndpoint;
     this.targetSystems = new HashSet<>();
     this.customYamlFiles = new HashSet<>();
-    this.intervalMillis = 1000;
     this.extraJars = new ArrayList<>();
   }
 
@@ -54,12 +52,6 @@ public JmxScraperContainer withTargetSystem(String targetSystem) {
     return this;
   }
 
-  @CanIgnoreReturnValue
-  public JmxScraperContainer withIntervalMillis(int intervalMillis) {
-    this.intervalMillis = intervalMillis;
-    return this;
-  }
-
   @CanIgnoreReturnValue
   public JmxScraperContainer withRmiServiceUrl(String host, int port) {
     // TODO: adding a way to provide 'host:port' syntax would make this easier for end users
@@ -132,7 +124,8 @@ public void start() {
       throw new IllegalStateException("Missing service URL");
     }
     arguments.add("-Dotel.jmx.service.url=" + serviceUrl);
-    arguments.add("-Dotel.jmx.interval.milliseconds=" + intervalMillis);
+    // always use a very short export interval for testing
+    arguments.add("-Dotel.metric.export.interval=1s");
 
     if (user != null) {
       arguments.add("-Dotel.jmx.username=" + user);

jmx-scraper/src/main/java/io/opentelemetry/contrib/jmxscraper/JmxScraper.java

@@ -66,6 +66,9 @@ public static void main(String[] args) {
 
       JmxScraperConfig scraperConfig = configCustomizer.getScraperConfig();
 
+      long exportSeconds = scraperConfig.getSamplingInterval().toMillis() / 1000;
+      logger.log(Level.INFO, "metrics export interval (seconds) =  " + exportSeconds);
+
       JmxMetricInsight service =
           JmxMetricInsight.createService(
               GlobalOpenTelemetry.get(), scraperConfig.getSamplingInterval().toMillis());

jmx-scraper/src/test/resources/validConfig.properties

@@ -1,7 +1,6 @@
 otel.jmx.service.url=service:jmx:rmi:///jndi/rmi://myhost:12345/jmxrmi
 otel.jmx.custom.scraping.config=/my/scraping-config.yaml
 otel.jmx.target.system=jvm,cassandra
-otel.jmx.interval.milliseconds=20000
 otel.metrics.exporter=otlp
 otel.metric.export.interval=1000
 otel.exporter.otlp.endpoint=https://myotlpendpoint
@@ -17,4 +16,3 @@ javax.net.ssl.keyStoreType=JKS
 javax.net.ssl.trustStore=/my/trust/store
 javax.net.ssl.trustStorePassword=def456
 javax.net.ssl.trustStoreType=JKS
-otel.jmx.aggregate.across.mbeans=true