make collections in config not modifiable

SylvainJuge · SylvainJuge · commit 911eefe401e6 · 2025-01-29T09:17:34.000+01:00
diff --git a/jmx-scraper/src/main/java/io/opentelemetry/contrib/jmxscraper/config/JmxScraperConfig.java b/jmx-scraper/src/main/java/io/opentelemetry/contrib/jmxscraper/config/JmxScraperConfig.java
@@ -171,8 +171,8 @@ public static JmxScraperConfig fromConfig(ConfigProperties config) {
           }
         });
 
-    scraperConfig.jmxConfig = jmxConfig;
-    scraperConfig.targetSystems = new HashSet<>(targetSystem);
+    scraperConfig.jmxConfig = Collections.unmodifiableList(jmxConfig);
+    scraperConfig.targetSystems = Collections.unmodifiableSet(new HashSet<>(targetSystem));
 
     scraperConfig.username = config.getString("otel.jmx.username");
     scraperConfig.password = config.getString("otel.jmx.password");

Original file line number	Diff line number	Diff line change
`@@ -171,8 +171,8 @@ public static JmxScraperConfig fromConfig(ConfigProperties config) {`
`171`	`171`	`}`
`172`	`172`	`});`
`173`	`173`
`174`		`- scraperConfig.jmxConfig = jmxConfig;`
`175`		`- scraperConfig.targetSystems = new HashSet<>(targetSystem);`
	`174`	`+ scraperConfig.jmxConfig = Collections.unmodifiableList(jmxConfig);`
	`175`	`+ scraperConfig.targetSystems = Collections.unmodifiableSet(new HashSet<>(targetSystem));`
`176`	`176`
`177`	`177`	`scraperConfig.username = config.getString("otel.jmx.username");`
`178`	`178`	`scraperConfig.password = config.getString("otel.jmx.password");`