fix(deps): update dependency com.google.errorprone:error_prone_core to v2.37.0 (#1805)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Lauri Tulmin <[email protected]>

Author: renovate[bot]

buildSrc/src/main/kotlin/otel.errorprone-conventions.gradle.kts

@@ -79,6 +79,9 @@ tasks {
         // cognitive load is dubious.
         disable("YodaCondition")
 
+        // We get this warning in modules that compile for old java versions
+        disable("StringConcatToTextBlock")
+
         if (name.contains("Jmh") || name.contains("Test")) {
           // Allow underscore in test-type method names
           disable("MemberName")

dependencyManagement/build.gradle.kts

@@ -26,7 +26,7 @@ dependencies {
     api("com.google.auto.value:auto-value:1.11.0")
     api("com.google.auto.value:auto-value-annotations:1.11.0")
     api("com.google.errorprone:error_prone_annotations:2.37.0")
-    api("com.google.errorprone:error_prone_core:2.36.0")
+    api("com.google.errorprone:error_prone_core:2.37.0")
     api("io.github.netmikey.logunit:logunit-jul:2.0.0")
     api("io.opentelemetry.proto:opentelemetry-proto:1.5.0-alpha")
     api("io.prometheus:simpleclient:0.16.0")

jfr-connection/src/main/java/io/opentelemetry/contrib/jfr/connection/RecordingOptions.java

@@ -66,7 +66,8 @@ private enum Option {
 
   /* If the arg is null or an empty String, return the Option's default. */
   private static String normalize(String arg, Option option) {
-    return arg == null || (arg = arg.trim()).isEmpty() ? option.defaultValue : arg;
+    arg = arg == null ? "" : arg.trim();
+    return arg.isEmpty() ? option.defaultValue : arg;
   }
 
   /**