Fix required status check #1545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-splk
reviewed
Nov 18, 2024
|
|
||
| required-status-check: | ||
| if: github.event_name == 'pull_request' | ||
| if: github.event_name == 'pull_request' && always() |
There was a problem hiding this comment.
I'm not following how this helps. Isn't && always() basically && true which is always true?
There was a problem hiding this comment.
one would think...
and you can see the difference below, required-status-check is run and fails (and so should block merging even after someone approves this PR), whereas in #1542 for example, required-status-check is skipped (and therefore didn't block merging)
|
I'm going to rebase now that #1546 has been merged, which should fix the integration tests and make |
breedx-splk
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem that I was able to merge #1544 even though one of the tests was failing.