Skip to content

Conversation

@trask
Copy link
Member

@trask trask commented Dec 12, 2024

No description provided.

@trask trask requested a review from a team December 12, 2024 23:00
Comment on lines +20 to +37
### JMX metrics

- Align HBase metric units to semconv
([#1538](https://github.com/open-telemetry/opentelemetry-java-contrib/pull/1538))
- Align Cassandra metric units to semconv
([#1591](https://github.com/open-telemetry/opentelemetry-java-contrib/pull/1591))
- Align Tomcat metric units to semconv
([#1589](https://github.com/open-telemetry/opentelemetry-java-contrib/pull/1589))
- Align JVM units to semconv
([#1593](https://github.com/open-telemetry/opentelemetry-java-contrib/pull/1593))

### JMX scraper - New 🌟

The future of the [JMX metrics](./jmx-metrics/README.md) component,
built on top of the
[JMX metrics](https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/jmx-metrics/javaagent#jmx-metric-insight)
component from the opentelemetry-java-instrumentation repository.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

#!/bin/bash -e

grep -Po "val stableVersion = \"\K[0-9]+.[0-9]+.[0-9]+" version.gradle.kts
grep "val stableVersion = " version.gradle.kts | grep -Eo "[0-9]+.[0-9]+.[0-9]+"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested both on debian and macos...the grep -p one fails on a mac, so that seems like a worthy improvement when developing locally....

Copy link
Member Author

@trask trask Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some reason grep -P used to work for me (windows / git bash) but no longer 🤷‍♂️

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-P is probably a GNU grep extension. Try running grep --version. Mac uses grep (BSD grep, GNU compatible) 2.6.0-FreeBSD brew install grep installs gnu grep as ggrep.

([#1589](https://github.com/open-telemetry/opentelemetry-java-contrib/pull/1589))
- Align JVM units to semconv
([#1593](https://github.com/open-telemetry/opentelemetry-java-contrib/pull/1593))

Copy link
Contributor

@robsunday robsunday Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one more for ActiveMQ: #1553
and I think also for Jetty: #1517

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, it looks like these were included in the last release, but I missed adding them to the change log / release notes

I'll send a separate PR to update the change log for 1.41.0 and I'll manually update the release notes

@trask trask merged commit 951d5a3 into open-telemetry:main Dec 13, 2024
14 checks passed
@trask trask deleted the changelog branch December 13, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants