Revert "Change to release after SDK and before Instrumentation (#1581)" #1603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…telemetry#1581)" This reverts commit 2b46b8c.
github-actions
bot
assigned
anosek-an,
breedx-splk,
jeanbisutti,
laurit,
mateuszrzeszutek,
robsunday and
SylvainJuge
github-actions
bot
requested review from
SylvainJuge,
anosek-an,
breedx-splk,
jeanbisutti,
laurit,
mateuszrzeszutek and
robsunday
breedx-splk
approved these changes
Dec 13, 2024
Contributor
breedx-splk
left a comment
breedx-splk
left a comment
There was a problem hiding this comment.
Thanks. It's a little unfortunate, but let's get unblocked before discussing again for next time. :)
Mentioning #1581 here for the easy click.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(it also broke the release process)
but more importantly, I think the more general dependency direction we want to promote is having contrib components using
opentelemetry-instrumentation-apiandopentelemetry-javaagent-extension-apiI'd prefer to explore moving contrib components into the instrumentation repo if we are including them in the java agent distribution
cc @jackshirazi