Skip to content

increase timeout for tests - to tolerate high loads #1607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 16, 2024
Merged

increase timeout for tests - to tolerate high loads #1607

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e66b8c
increase timeout for tests - to tolerate high loads
zeitlinger Dec 16, 2024
c1bbb58
Update baggage-processor/src/test/java/io/opentelemetry/contrib/bagga…
zeitlinger Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../test/java/io/opentelemetry/contrib/baggage/processor/BaggageProcessorCustomizerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ private static void assertCustomizer(
}

await()
.atMost(Duration.ofSeconds(1))
.atMost(Duration.ofSeconds(60))
Copy link
Contributor

@laurit laurit Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In instrumentation repo waitAndAssertTraces uses awaitility under the hood with default timeout of 10s. While 60s does the job I probably would have started with a lower timeout, like the default 10 or maybe 20.

Copy link
Member Author

@zeitlinger zeitlinger Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

.untilAsserted(
() -> {
assertThat(spanExporter.getFinishedSpanItems())
Expand Down
Loading