Skip to content

Conversation

@KarstenSchnitter
Copy link
Contributor

Description:

Adds a new module, that parses the environment variable VCAP_APPLICATION for properties required for the CloudFoundry resource convention. This variable is present for applications running on CloudFoundry and contains all necessary information in a JSON object.

This PR moves the code proposed in open-telemetry/opentelemetry-java-instrumentation#12861 to this repository

Existing Issue(s):

open-telemetry/opentelemetry-java-instrumentation#12861 and open-telemetry/opentelemetry-java-instrumentation#12862

Testing:

Unittests for the new functionality was added.

Documentation:

Please advise on necessary changes.

Outstanding items:

The could be a service name provider using the CloudFoundry application name, if no other source for the service name was found. I was unsure of the priority of such a provider, so I kept it for a later change.

Adds a new module, that parses the environment variable
VCAP_APPLICATION for properties required for the CloudFoundry
resource convention. This variable is present for applications
running on CloudFoundry and contains all necessary information
in a JSON object.

Signed-off-by: Karsten Schnitter <[email protected]>
@trask
Copy link
Member

trask commented Dec 17, 2024

can you add a README.md similar to other components, and add the component to https://github.com/open-telemetry/opentelemetry-java-contrib/blob/main/.github/component_owners.yml? do you know anyone else who would like to be a component owner for this? we really like to have (at least) two component owners from (at least) two different companies

Code owners for the CloudFoundry module are yet to be
determined.

Signed-off-by: Karsten Schnitter <[email protected]>
@KarstenSchnitter
Copy link
Contributor Author

@trask If I read the comment in the code_owners.yml correctly, this requires for me to be part of the OpenTelemetry Github organization, right? Currently, I am not a member. I just started with contributions to OpenTelemetry, e.g., open-telemetry/semantic-conventions#624. I do not want to disregard the OpenTelemetry community guidelines by adding myself to the code owners. How do you suggest to proceed?

I have added a draft version of the README.md without code owner references to me.

@trask
Copy link
Member

trask commented Jan 11, 2025

hi @KarstenSchnitter! go ahead and yourself to component_owners.yml (which is different from CODEOWNERS)

we will need component owner(s) before we merge this PR

once we get further in reviewing this PR, you can open a membership request and @breedx-splk and myself can be your sponsors

@KarstenSchnitter
Copy link
Contributor Author

@trask can you have another look at this?

Uses main branch.
Uses plural form to align with aws-resources and gcp-resources subprojects.

Signed-off-by: Karsten Schnitter <[email protected]>
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's see if we can find a second component owner https://cloud-native.slack.com/archives/C014L2KCTE3/p1738277694079839

Co-authored-by: Trask Stalnaker <[email protected]>
@trask trask added this to the v1.44.0 milestone Feb 7, 2025
@trask
Copy link
Member

trask commented Feb 7, 2025

hi @KarstenSchnitter, we haven't forgotten about this! will try to get it reviewed and merged before next week's release

@trask trask enabled auto-merge (squash) February 21, 2025 21:15
@trask trask merged commit 2858a2c into open-telemetry:main Feb 21, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants