Skip to content

draft: add jvm.fd.open and jvm.runtime.uptime to jmx configs #1665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

draft: add jvm.fd.open and jvm.runtime.uptime to jmx configs #1665

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
774a310
add jvm.fd.open and jvm.runtime.uptime to jmx configs
schmikei Jan 22, 2025
9bcbf44
consolidate name on jvm.file_descriptor.count
schmikei Mar 18, 2025
374b3ed
Merge branch 'main' of github.com:open-telemetry/opentelemetry-java-c…
schmikei Mar 18, 2025
2661e02
fix test
schmikei Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...va/io/opentelemetry/contrib/jmxmetrics/target_systems/JvmTargetSystemIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,15 @@

package io.opentelemetry.contrib.jmxmetrics.target_systems;

import io.opentelemetry.contrib.jmxmetrics.AbstractIntegrationTest;
import java.util.Arrays;
import java.util.List;

import org.junit.jupiter.api.Test;
import org.testcontainers.containers.GenericContainer;
import org.testcontainers.junit.jupiter.Container;

import io.opentelemetry.contrib.jmxmetrics.AbstractIntegrationTest;

class JvmTargetSystemIntegrationTest extends AbstractIntegrationTest {

JvmTargetSystemIntegrationTest() {
Expand Down Expand Up @@ -55,6 +57,8 @@ void endToEnd() {
metric -> assertGauge(metric, "jvm.memory.nonheap.init", "current non-heap usage", "By"),
metric -> assertGauge(metric, "jvm.memory.nonheap.max", "current non-heap usage", "By"),
metric -> assertGauge(metric, "jvm.memory.nonheap.used", "current non-heap usage", "By"),
metric -> assertGauge(metric, "jvm.runtime.uptime", "uptime", "ms"),
metric -> assertGauge(metric, "jvm.fd.open", "open file descriptors", "1"),
metric ->
assertTypedGauge(
metric, "jvm.memory.pool.committed", "current memory pool usage", "By", gcLabels),
Expand Down
9 changes: 9 additions & 0 deletions jmx-metrics/src/main/resources/target-systems/jvm.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,15 @@ otel.instrument(memory, "jvm.memory.heap", "current heap usage",
otel.instrument(memory, "jvm.memory.nonheap", "current non-heap usage",
"By", "NonHeapMemoryUsage", otel.&longValueCallback)

def runtime = otel.mbean("java.lang:type=Runtime")
otel.instrument(runtime, "jvm.runtime.uptime", "uptime",
"ms", "Uptime", otel.&longValueCallback)

def os = otel.mbean("java.lang:type=OperatingSystem")
Copy link
Member

@ridwanmsharif ridwanmsharif Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very familiar with how this works, what happens on Windows?

otel.instrument(os, "jvm.fd.open", "open file descriptors",
"1", "OpenFileDescriptorCount", otel.&longValueCallback)


def memoryPool = otel.mbeans("java.lang:type=MemoryPool,*")
otel.instrument(memoryPool, "jvm.memory.pool", "current memory pool usage",
"By", ["name" : { mbean -> mbean.name().getKeyProperty("name") }],
Expand Down
Loading