add xray-lambda configurable propagator to autoconfigure spi #1669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerbenson
approved these changes
Jan 23, 2025
Member
|
(This PR fixes an oversight where I forgot to add the spi when I created the class initially.) |
srprash
approved these changes
Jan 23, 2025
trask
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Bug fix - The xray-lambda spi wasnt added
Existing Issue(s):
AWS Xray Propagator missing SPI file for xray-lambda propagation
Testing:
No testing was performed
Documentation:
N/A
Outstanding items:
I am still investigating how to get xray-lambda to work with the java wrapper layer in this issue: open-telemetry/opentelemetry-lambda#1669