jmx scraper connection test #1684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SylvainJuge
commented
Feb 3, 2025
| } | ||
| } | ||
|
|
||
| private static void checkConnectionLogs(JmxScraperContainer scraper, boolean expectedOk) { |
There was a problem hiding this comment.
[for reviewer] we have to parse and check scraper logs in order to know if the connection is OK or not, this is because we can't access the process exit value when the program completes.
| */ | ||
| @CanIgnoreReturnValue | ||
| public TestAppContainer withHostAccessFixedJmxPort(int port) { | ||
| // To get host->container JMX connection working docker must expose JMX/RMI port under the same |
There was a problem hiding this comment.
[for reviewer] this is no longer necessary as we only rely on container-to-container communication and we don't have to use docker NAT to access the JMX endpoint.
| import org.junit.jupiter.api.Test; | ||
| import org.testcontainers.containers.Network; | ||
|
|
||
| public class JmxConnectorBuilderTest { |
There was a problem hiding this comment.
[for reviewer] this is replaced by JmxConnectionTest.
robsunday
reviewed
Feb 4, 2025
jmx-scraper/src/main/java/io/opentelemetry/contrib/jmxscraper/JmxScraper.java
Outdated
Show resolved
Hide resolved
jmx-scraper/src/main/java/io/opentelemetry/contrib/jmxscraper/JmxScraper.java
Show resolved
Hide resolved
robsunday
approved these changes
Feb 5, 2025
jmx-scraper/src/main/java/io/opentelemetry/contrib/jmxscraper/JmxScraper.java
Show resolved
Hide resolved
…ontrib into jmx-scraper-test
…ontrib into jmx-scraper-test
robsunday
approved these changes
Feb 7, 2025
This was referenced Feb 7, 2025
trask
approved these changes
Feb 10, 2025
breedx-splk
pushed a commit
to breedx-splk/opentelemetry-java-contrib
that referenced
this pull request
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1681
This PR adds a new CLI argument to enable end-users to test JMX connection.
JMX connection is expected to be tedious to setup and will benefit from a fast feedback loop as there are multiple things that can be problematic during setup:
Also, testing connection through this mean allow us to validate configuration usage with CLI interface and avoids having any complication due to JMX/RMI port mapping which is not NAT friendly (open connection on a port, then another one is used afterwards).