Add FOSSA license scanning #1718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
SylvainJuge,
breedx-splk and
robsunday
trask
commented
Feb 8, 2025
Comment on lines
-86
to
-95
| for (dependency in CORE_DEPENDENCIES) { | ||
| api(dependency) | ||
| val split = dependency.split(':') | ||
| dependencyVersions[split[0]] = split[2] | ||
| } | ||
| for (dependency in DEPENDENCIES) { | ||
| api(dependency) | ||
| val split = dependency.split(':') | ||
| dependencyVersions[split[0]] = split[2] | ||
| } |
There was a problem hiding this comment.
getting rid of this was unrelated, but we don't use the dependencyVersions constants, and inlining the dependencies directly into this section seems so much more straightforward
trask
force-pushed
the
fossa
branch
2 times, most recently
from
acc2415 to
8562260
Compare
laurit
approved these changes
Feb 10, 2025
breedx-splk
pushed a commit
to breedx-splk/opentelemetry-java-contrib
that referenced
this pull request
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.